From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Hans de Goede <hdegoede@redhat.com>
Subject: [PATCH v4 11/16] drm/i915/dsi: Extract common soc_gpio_set_value() helper
Date: Fri, 3 Nov 2023 22:18:26 +0200 [thread overview]
Message-ID: <20231103201831.1037416-12-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20231103201831.1037416-1-andriy.shevchenko@linux.intel.com>
Extract a common soc_gpio_set_value() helper that may be used by a few SoCs.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 46 +++++++++++---------
1 file changed, 26 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 0f9da0168a7b..9847a92fdfc3 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -243,6 +243,31 @@ static const u8 *mipi_exec_delay(struct intel_dsi *intel_dsi, const u8 *data)
return data;
}
+static void soc_gpio_set_value(struct intel_connector *connector, const char *con_id,
+ u8 gpio_index, bool value)
+{
+ struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
+ /* XXX: this table is a quick ugly hack. */
+ static struct gpio_desc *soc_gpio_table[U8_MAX + 1];
+ struct gpio_desc *gpio_desc = soc_gpio_table[gpio_index];
+
+ if (gpio_desc) {
+ gpiod_set_value(gpio_desc, value);
+ } else {
+ gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
+ con_id, gpio_index,
+ value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
+ if (IS_ERR(gpio_desc)) {
+ drm_err(&dev_priv->drm,
+ "GPIO index %u request failed (%pe)\n",
+ gpio_index, gpio_desc);
+ return;
+ }
+
+ soc_gpio_table[gpio_index] = gpio_desc;
+ }
+}
+
static void vlv_gpio_set_value(struct intel_connector *connector,
u8 gpio_source, u8 gpio_index, bool value)
{
@@ -348,26 +373,7 @@ static void chv_gpio_set_value(struct intel_connector *connector,
static void bxt_gpio_set_value(struct intel_connector *connector,
u8 gpio_index, bool value)
{
- struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
- /* XXX: this table is a quick ugly hack. */
- static struct gpio_desc *bxt_gpio_table[U8_MAX + 1];
- struct gpio_desc *gpio_desc = bxt_gpio_table[gpio_index];
-
- if (!gpio_desc) {
- gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
- NULL, gpio_index,
- value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
- if (IS_ERR_OR_NULL(gpio_desc)) {
- drm_err(&dev_priv->drm,
- "GPIO index %u request failed (%ld)\n",
- gpio_index, PTR_ERR(gpio_desc));
- return;
- }
-
- bxt_gpio_table[gpio_index] = gpio_desc;
- }
-
- gpiod_set_value(gpio_desc, value);
+ soc_gpio_set_value(connector, NULL, gpio_index, value);
}
enum {
--
2.40.0.1.gaa8946217a0b
next prev parent reply other threads:[~2023-11-03 20:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 20:18 [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO Andy Shevchenko
2023-11-03 20:18 ` [PATCH v4 01/16] drm/i915/dsi: assume BXT gpio works for non-native GPIO Andy Shevchenko
2023-11-03 20:18 ` [PATCH v4 02/16] drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915 Andy Shevchenko
2023-11-03 20:18 ` [PATCH v4 03/16] drm/i915/dsi: clarify GPIO exec sequence Andy Shevchenko
2023-11-03 20:18 ` [PATCH v4 04/16] drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value() Andy Shevchenko
2023-11-03 20:18 ` [PATCH v4 05/16] drm/i915/dsi: bxt/icl GPIO set value do not need gpio source Andy Shevchenko
2023-11-03 20:18 ` [PATCH v4 06/16] drm/i915/dsi: Replace while(1) with one with clear exit condition Andy Shevchenko
2023-11-03 20:18 ` [PATCH v4 07/16] drm/i915/dsi: Get rid of redundant 'else' Andy Shevchenko
2023-11-03 20:18 ` [PATCH v4 08/16] drm/i915/dsi: Replace check with a (missing) MIPI sequence name Andy Shevchenko
2023-11-03 20:18 ` [PATCH v4 09/16] drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init() Andy Shevchenko
2023-11-03 20:18 ` [PATCH v4 10/16] drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value() Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko [this message]
2023-11-03 20:18 ` [PATCH v4 12/16] drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back Andy Shevchenko
2023-11-03 20:18 ` [PATCH v4 13/16] drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities Andy Shevchenko
2023-11-03 20:18 ` [PATCH v4 14/16] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back Andy Shevchenko
2023-11-03 20:18 ` [PATCH v4 15/16] drm/i915/dsi: Combine checks in mipi_exec_gpio() Andy Shevchenko
2023-11-03 20:18 ` [PATCH v4 16/16] drm/i915/iosf: Drop unused APIs Andy Shevchenko
2023-11-16 8:58 ` [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO Hans de Goede
2023-11-16 10:15 ` Jani Nikula
2023-11-17 21:05 ` Andy Shevchenko
2023-11-21 10:28 ` Jani Nikula
2023-11-17 21:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231103201831.1037416-12-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox