Re: [PATCH 5.15 000/128] 5.15.138-rc1 review

Greg Kroah-Hartman
2023-11-07T20:22:29Z

On Mon, Nov 06, 2023 at 08:24:43PM +0530, Harshit Mogalapalli wrote:
> Hello Greg,
>
> On 06/11/23 6:32 pm, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.15.138 release.
> > There are 128 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 08 Nov 2023 13:02:46 +0000.
> > Anything received after that time might be too late.
> >
>
> I am seeing a build failure with perf:
>
> tools/perf/util/evlist.c: In function evlist__add_aux_dummy:
> tools/perf/util/evlist.c:266:31: error: implicit declaration of function
> evlist__dummy_event; did you mean evlist__add_sb_event’?
> [-Werror=implicit-function-declaration]
> 266 | struct evsel *evsel = evlist__dummy_event(evlist);
> | ^~~~~~~~~~~~~~~~~~~
> | evlist__add_sb_event
>
>
> I think we should drop these three commits:
>
> 20a5799cae7dc perf evlist: Avoid frequency mode for the dummy event
> 7de783c81c7e7 perf tools: Get rid of evlist__add_on_all_cpus()
> 141ce9207068e perf evlist: Add evlist__add_dummy_on_all_cpus()

Thanks, I've dropped all of these from 5.15.y and 5.10.y now.

greg k-h