From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Chen Ni <nichen@iscas.ac.cn>,
linux-kernel@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>
Subject: [PATCH v3 0/2] mfd: intel-lpss: refactor PCI probe and common IRQ check
Date: Mon, 6 Nov 2023 20:40:50 +0200 [thread overview]
Message-ID: <20231106184052.1166579-1-andriy.shevchenko@linux.intel.com> (raw)
The PCI code can be refactored to use respective PCI APIs instead of
direct dereference of struct pci_dev members.
With that, we may unshadow the error code that is promoted in the irq
field of info structure. PCI core shouldn't propagate 0 as a value
there, and in case it happens it reveals a bug somewhere else.
Changelog:
v2 -> v3:
1. Refactored PCI glue driver a bit (a new patch)
2. Updated commit message in the original patch
v1 -> v2:
1. Update commit message
2. Fix IRQ check in intel_lpcc_probe()
Andy Shevchenko (1):
mfd: intel-lpss: Use PCI APIs instead of derefereincing
Chen Ni (1):
mfd: intel-lpss: Amend IRQ check
drivers/mfd/intel-lpss-pci.c | 8 ++++++--
drivers/mfd/intel-lpss.c | 5 ++++-
2 files changed, 10 insertions(+), 3 deletions(-)
--
2.40.0.1.gaa8946217a0b
next reply other threads:[~2023-11-06 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 18:40 Andy Shevchenko [this message]
2023-11-06 18:40 ` [PATCH v3 1/2] mfd: intel-lpss: Use PCI APIs instead of derefereincing Andy Shevchenko
2023-11-23 11:17 ` Lee Jones
2023-11-06 18:40 ` [PATCH v3 2/2] mfd: intel-lpss: Amend IRQ check Andy Shevchenko
2023-11-23 11:18 ` Lee Jones
2023-11-23 11:17 ` [PATCH v3 0/2] mfd: intel-lpss: refactor PCI probe and common " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106184052.1166579-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox