From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FE8AC4332F for ; Mon, 6 Nov 2023 12:47:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232013AbjKFMrx (ORCPT ); Mon, 6 Nov 2023 07:47:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232018AbjKFMr2 (ORCPT ); Mon, 6 Nov 2023 07:47:28 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95D0910DD for ; Mon, 6 Nov 2023 04:47:16 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29123C433C7; Mon, 6 Nov 2023 12:47:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699274836; bh=ZKPkoYHE+kdPCNAugjno/omWZzc7yMN7RXy8qs3DD5k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=giNYOukD28FBmGEenY1xFYwWuBmV8/q/WR0g1ZPiIKOpz2FvZN1YF3y8ncXXdiXru ic8wuicePL6JiQY8EkJaNqGFbHqlORc90fpqo9dPUOLx0UsYqvjyZzdRJ3MPwCLFdK tcAycTq9JxTcslU3E8TF914Y/Srma8S+f2wajFRD4VoRF+L8YAHXW+j4klmaDZyUuE qxpIpfqJ8WwDtmg6D1erTp35IuKdrinzKFXNv87uTto31RmsT+TkamFExYM0eU1sjv elo7YvY1YyCkl7bUEGeQRzlMTgxCE3Ff5ivV3bYwZ0FVAGXZU8mFdCghMF3+kyFeXj BYiMAISbrqavA== Date: Mon, 6 Nov 2023 21:47:08 +0900 From: Masami Hiramatsu (Google) To: Peter Zijlstra Cc: Steven Rostedt , Alexei Starovoitov , Florent Revest , linux-trace-kernel@vger.kernel.org, LKML , Martin KaFai Lau , bpf , Sven Schnelle , Alexei Starovoitov , Jiri Olsa , Arnaldo Carvalho de Melo , Daniel Borkmann , Alan Maguire , Mark Rutland , Thomas Gleixner , Guo Ren Subject: Re: [RFC PATCH 24/32] x86/ftrace: Enable HAVE_FUNCTION_GRAPH_FREGS Message-Id: <20231106214708.d132cfd9984beac55e4b420e@kernel.org> In-Reply-To: <20231106101932.GJ8262@noisy.programming.kicks-ass.net> References: <169920038849.482486.15796387219966662967.stgit@devnote2> <169920068069.482486.6540417903833579700.stgit@devnote2> <20231105172536.GA7124@noisy.programming.kicks-ass.net> <20231105141130.6ef7d8bd@rorschach.local.home> <20231105231734.GE3818@noisy.programming.kicks-ass.net> <20231105183301.38be5598@rorschach.local.home> <20231105183409.424bc368@rorschach.local.home> <20231106093850.62702d5bf1779e30cdecf1eb@kernel.org> <20231106101932.GJ8262@noisy.programming.kicks-ass.net> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Nov 2023 11:19:32 +0100 Peter Zijlstra wrote: > On Mon, Nov 06, 2023 at 09:38:50AM +0900, Masami Hiramatsu wrote: > > On Sun, 5 Nov 2023 18:34:09 -0500 > > Steven Rostedt wrote: > > > > > On Sun, 5 Nov 2023 18:33:01 -0500 > > > Steven Rostedt wrote: > > > > > > > For x86_64, that would be: > > > > > > > > rdi, rsi, rdx, r8, r9, rsp > > > > > > I missed rcx. > > > > I would like to add rax to the list so that it can handle the return value too. :) > > So something like so? > > > diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h > index 897cf02c20b1..71bfe27594a5 100644 > --- a/arch/x86/include/asm/ftrace.h > +++ b/arch/x86/include/asm/ftrace.h > @@ -36,6 +36,10 @@ static inline unsigned long ftrace_call_adjust(unsigned long addr) > > #ifdef CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS > struct ftrace_regs { > + /* > + * Partial, filled with: > + * rax, rcx, rdx, rdi, rsi, r8, r9, rsp Don't we need rbp too? (for frame pointer) > + */ > struct pt_regs regs; > }; -- Masami Hiramatsu (Google)