From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Vasily Averin <vasily.averin@linux.dev>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Minchan Kim <minchan@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-block@vger.kernel.org
Subject: Re: zram: zram_free_page calls in zram_meta_free
Date: Tue, 7 Nov 2023 16:23:35 +0900 [thread overview]
Message-ID: <20231107072335.GA11577@google.com> (raw)
In-Reply-To: <ebd87e1e-f941-498a-870e-15743ca3fb1f@linux.dev>
On (23/11/06 23:42), Vasily Averin wrote:
> The only place where content of zram entry is accessed and even changed without taken zran lock is
> zram_free_page() calls from zram_meta_free().
>
> It does not look like problem because zram should not have any users at this point,
> however I still do not understand why this is required?
It's simply pointless. Reset is performed under write init_lock,
which is an upper level per-device lock.
prev parent reply other threads:[~2023-11-07 7:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 20:42 zram: zram_free_page calls in zram_meta_free Vasily Averin
2023-11-07 7:23 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231107072335.GA11577@google.com \
--to=senozhatsky@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=vasily.averin@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox