From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Usyskin, Alexander" <alexander.usyskin@intel.com>
Cc: "De Marchi, Lucas" <lucas.demarchi@intel.com>,
"Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"Winkler, Tomas" <tomas.winkler@intel.com>,
"Lubart, Vitaly" <vitaly.lubart@intel.com>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] mei: pxp: add dependency on Xe driver
Date: Tue, 7 Nov 2023 15:35:56 +0100 [thread overview]
Message-ID: <2023110718-obscure-carrot-3467@gregkh> (raw)
In-Reply-To: <CY5PR11MB6366D1F5EB27DA07628B42DCEDA9A@CY5PR11MB6366.namprd11.prod.outlook.com>
On Tue, Nov 07, 2023 at 02:26:17PM +0000, Usyskin, Alexander wrote:
> >
> > On Tue, Nov 07, 2023 at 03:46:06PM +0200, Alexander Usyskin wrote:
> > > Optionally depend on either i915 or Xe drivers.
> > >
> > > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> > > ---
> > > drivers/misc/mei/pxp/Kconfig | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig
> > > index 4029b96afc04..d9ae5483567f 100644
> > > --- a/drivers/misc/mei/pxp/Kconfig
> > > +++ b/drivers/misc/mei/pxp/Kconfig
> > > @@ -1,11 +1,10 @@
> > > -
> >
> > Why this change here?
>
> I've been told that SPDX should be the first line in the file,
> but here fist line is an empty line.
That is correct, and should be fixed up, but you didn't say that you
made this change in your changelog text so I didn't know why it was
there.
> I can drop this change if it is inappropriate to put it in this patch.
It should go in a separate patch please.
thanks,
greg k-h
next prev parent reply other threads:[~2023-11-07 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 13:46 [PATCH 0/5] mei: hdcp/pxp: adapt for Xe driver Alexander Usyskin
2023-11-07 13:46 ` [PATCH 1/5] Revert "mei/hdcp: Also enable for XE" Alexander Usyskin
2023-11-07 14:10 ` Greg Kroah-Hartman
2023-11-07 13:46 ` [PATCH 2/5] mei: hdcp: match without driver name Alexander Usyskin
2023-11-07 13:46 ` [PATCH 3/5] mei: pxp: " Alexander Usyskin
2023-11-07 13:46 ` [PATCH 4/5] mei: hdcp: add dependency on Xe driver Alexander Usyskin
2023-11-07 13:46 ` [PATCH 5/5] mei: pxp: " Alexander Usyskin
2023-11-07 14:11 ` Greg Kroah-Hartman
2023-11-07 14:26 ` Usyskin, Alexander
2023-11-07 14:35 ` Greg Kroah-Hartman [this message]
2023-11-27 13:32 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023110718-obscure-carrot-3467@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexander.usyskin@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tomas.winkler@intel.com \
--cc=vitaly.lubart@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox