From: Christoph Hellwig <hch@lst.de>
To: Li Lingfeng <lilingfeng@huaweicloud.com>
Cc: josef@toxicpanda.com, linux-kernel@vger.kernel.org, hch@lst.de,
linux-block@vger.kernel.org, nbd@other.debian.org,
axboe@kernel.dk, chaitanya.kulkarni@wdc.com,
yukuai1@huaweicloud.com, houtao1@huawei.com, yi.zhang@huawei.com,
yangerkun@huawei.com, lilingfeng3@huawei.com
Subject: Re: [PATCH v2] nbd: fix uaf in nbd_open
Date: Wed, 8 Nov 2023 08:19:25 +0100 [thread overview]
Message-ID: <20231108071925.GB4875@lst.de> (raw)
In-Reply-To: <20231107103435.2074904-1-lilingfeng@huaweicloud.com>
I don't think this is actually enough on it's own. You'll also
need to move al the teardown logic that is currently in
nbd_dev_remove. And with this you should be able to remove the
NULL check in nbd_open, and propably the nbd_index_mutex critical
section. Although that'll need a very careful audit.
prev parent reply other threads:[~2023-11-08 7:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 10:34 [PATCH v2] nbd: fix uaf in nbd_open Li Lingfeng
2023-11-07 15:05 ` Josef Bacik
2023-11-07 15:15 ` Jens Axboe
2023-11-08 7:19 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108071925.GB4875@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=houtao1@huawei.com \
--cc=josef@toxicpanda.com \
--cc=lilingfeng3@huawei.com \
--cc=lilingfeng@huaweicloud.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox