From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: 柳菁峰 <liujingfeng@qianxin.com>
Cc: Marco Elver <elver@google.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"security@kernel.org" <security@kernel.org>,
"syzkaller@googlegroups.com" <syzkaller@googlegroups.com>
Subject: Re: Reply: A null-ptr crash in linux-6.4 usb driver
Date: Wed, 8 Nov 2023 08:54:04 +0100 [thread overview]
Message-ID: <2023110809-headache-heaving-3472@gregkh> (raw)
In-Reply-To: <043105feee62401f833a06ea480a3b1b@qianxin.com>
On Wed, Nov 08, 2023 at 07:40:08AM +0000, 柳菁峰 wrote:
> I have made a patch that simply checks for null pointer, but I am not sure if this will affect certain functions or logic. I hope you can check it carefully.
>
> 1006c1006
> < if (dev->p->dead) {
> ---
> > if (!dev->p||dev->p->dead) {
Can you take a look at the file,
Documentation/process/submitting-patches.rst for how to properly
generate a patch? This does not give us any context to even know what
file you are changing.
Also, we have no context at all to even know what this is about at all,
what is this for?
confused,
greg k-h
next prev parent reply other threads:[~2023-11-08 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 7:40 Reply: A null-ptr crash in linux-6.4 usb driver 柳菁峰
2023-11-08 7:54 ` gregkh [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-08 8:56 柳菁峰
2023-11-08 9:08 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023110809-headache-heaving-3472@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=elver@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liujingfeng@qianxin.com \
--cc=rafael@kernel.org \
--cc=security@kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox