From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3923C4332F for ; Wed, 8 Nov 2023 16:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230248AbjKHQZ0 (ORCPT ); Wed, 8 Nov 2023 11:25:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbjKHQZX (ORCPT ); Wed, 8 Nov 2023 11:25:23 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A26D81BFA for ; Wed, 8 Nov 2023 08:25:21 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8E05C433C8; Wed, 8 Nov 2023 16:25:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1699460721; bh=QDP2PkpuNljZi5l7VgltxnPr6lgtd/xesU719E+bNwQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q24sJpFEgQcM0ZojLTFo7kRKdEfZ8kLMHPyttUjcyqoszAhE9uS54Yo1gjsw3wcD7 6UHYintdG8EEsSFJd6O1qEnM3CsGueWEWwHZ+e5Xr3VGU6bVOJvmUnooAwbshgshq1 hAQFWrAManfQFuXZpagDiJPjorzzfKxNIogIdC6Y= Date: Wed, 8 Nov 2023 17:25:18 +0100 From: Greg Kroah-Hartman To: Randy Dunlap Cc: Arnd Bergmann , Johan Hovold , Alex Elder , Arnd Bergmann , Ayush Singh , greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] greybus: beagleplay: select CONFIG_CRC_CCITT Message-ID: <2023110809-splendor-debtor-b073@gregkh> References: <20231108153429.1072732-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 08, 2023 at 08:12:57AM -0800, Randy Dunlap wrote: > > > On 11/8/23 07:34, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > Without the CRC_CCITT code, the new greybus driver fails to link: > > > > aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_append_tx_u8': > > gb-beagleplay.c:(.text+0x158): undefined reference to `crc_ccitt' > > aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `gb_tty_receive': > > gb-beagleplay.c:(.text+0x5c4): undefined reference to `crc_ccitt' > > > > Signed-off-by: Arnd Bergmann > > --- > > drivers/greybus/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig > > index 033d31dbf3b8..ab81ceceb337 100644 > > --- a/drivers/greybus/Kconfig > > +++ b/drivers/greybus/Kconfig > > @@ -20,6 +20,7 @@ if GREYBUS > > config GREYBUS_BEAGLEPLAY > > tristate "Greybus BeaglePlay driver" > > depends on SERIAL_DEV_BUS > > + select CRC_CCITT > > help > > Select this option if you have a BeaglePlay where CC1352 > > co-processor acts as Greybus SVC. > > Yes, same as my patch: > https://lore.kernel.org/lkml/20231031040909.21201-1-rdunlap@infradead.org/ > > I expect that Greg just hasn't gotten around to applying new patches/fixes yet. Nope, waiting until -rc1 is out, sorry. greg k-h