* [PATCH] greybus: beagleplay: select CONFIG_CRC_CCITT
@ 2023-11-08 15:34 Arnd Bergmann
2023-11-08 16:12 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2023-11-08 15:34 UTC (permalink / raw)
To: Johan Hovold, Alex Elder, Greg Kroah-Hartman
Cc: Arnd Bergmann, Ayush Singh, greybus-dev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Without the CRC_CCITT code, the new greybus driver fails to link:
aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_append_tx_u8':
gb-beagleplay.c:(.text+0x158): undefined reference to `crc_ccitt'
aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `gb_tty_receive':
gb-beagleplay.c:(.text+0x5c4): undefined reference to `crc_ccitt'
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/greybus/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig
index 033d31dbf3b8..ab81ceceb337 100644
--- a/drivers/greybus/Kconfig
+++ b/drivers/greybus/Kconfig
@@ -20,6 +20,7 @@ if GREYBUS
config GREYBUS_BEAGLEPLAY
tristate "Greybus BeaglePlay driver"
depends on SERIAL_DEV_BUS
+ select CRC_CCITT
help
Select this option if you have a BeaglePlay where CC1352
co-processor acts as Greybus SVC.
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] greybus: beagleplay: select CONFIG_CRC_CCITT
2023-11-08 15:34 [PATCH] greybus: beagleplay: select CONFIG_CRC_CCITT Arnd Bergmann
@ 2023-11-08 16:12 ` Randy Dunlap
2023-11-08 16:25 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2023-11-08 16:12 UTC (permalink / raw)
To: Arnd Bergmann, Johan Hovold, Alex Elder, Greg Kroah-Hartman
Cc: Arnd Bergmann, Ayush Singh, greybus-dev, linux-kernel
On 11/8/23 07:34, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without the CRC_CCITT code, the new greybus driver fails to link:
>
> aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_append_tx_u8':
> gb-beagleplay.c:(.text+0x158): undefined reference to `crc_ccitt'
> aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `gb_tty_receive':
> gb-beagleplay.c:(.text+0x5c4): undefined reference to `crc_ccitt'
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/greybus/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig
> index 033d31dbf3b8..ab81ceceb337 100644
> --- a/drivers/greybus/Kconfig
> +++ b/drivers/greybus/Kconfig
> @@ -20,6 +20,7 @@ if GREYBUS
> config GREYBUS_BEAGLEPLAY
> tristate "Greybus BeaglePlay driver"
> depends on SERIAL_DEV_BUS
> + select CRC_CCITT
> help
> Select this option if you have a BeaglePlay where CC1352
> co-processor acts as Greybus SVC.
Yes, same as my patch:
https://lore.kernel.org/lkml/20231031040909.21201-1-rdunlap@infradead.org/
I expect that Greg just hasn't gotten around to applying new patches/fixes yet.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] greybus: beagleplay: select CONFIG_CRC_CCITT
2023-11-08 16:12 ` Randy Dunlap
@ 2023-11-08 16:25 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2023-11-08 16:25 UTC (permalink / raw)
To: Randy Dunlap
Cc: Arnd Bergmann, Johan Hovold, Alex Elder, Arnd Bergmann,
Ayush Singh, greybus-dev, linux-kernel
On Wed, Nov 08, 2023 at 08:12:57AM -0800, Randy Dunlap wrote:
>
>
> On 11/8/23 07:34, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Without the CRC_CCITT code, the new greybus driver fails to link:
> >
> > aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_append_tx_u8':
> > gb-beagleplay.c:(.text+0x158): undefined reference to `crc_ccitt'
> > aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `gb_tty_receive':
> > gb-beagleplay.c:(.text+0x5c4): undefined reference to `crc_ccitt'
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > drivers/greybus/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig
> > index 033d31dbf3b8..ab81ceceb337 100644
> > --- a/drivers/greybus/Kconfig
> > +++ b/drivers/greybus/Kconfig
> > @@ -20,6 +20,7 @@ if GREYBUS
> > config GREYBUS_BEAGLEPLAY
> > tristate "Greybus BeaglePlay driver"
> > depends on SERIAL_DEV_BUS
> > + select CRC_CCITT
> > help
> > Select this option if you have a BeaglePlay where CC1352
> > co-processor acts as Greybus SVC.
>
> Yes, same as my patch:
> https://lore.kernel.org/lkml/20231031040909.21201-1-rdunlap@infradead.org/
>
> I expect that Greg just hasn't gotten around to applying new patches/fixes yet.
Nope, waiting until -rc1 is out, sorry.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-08 16:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-08 15:34 [PATCH] greybus: beagleplay: select CONFIG_CRC_CCITT Arnd Bergmann
2023-11-08 16:12 ` Randy Dunlap
2023-11-08 16:25 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox