Re: [PATCH v6 15/20] sched: Add proxy deactivate helper

[kernel test robot <lkp@intel.com>]

Hi John,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tip/locking/core]
[also build test WARNING on v6.6]
[cannot apply to tip/sched/core tip/master linus/master tip/auto-latest next-20231107]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/John-Stultz/sched-Unify-runtime-accounting-across-classes/20231107-033946
base:   tip/locking/core
patch link:    https://lore.kernel.org/r/20231106193524.866104-16-jstultz%40google.com
patch subject: [PATCH v6 15/20] sched: Add proxy deactivate helper
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231108/202311081028.yDLmCWgr-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231108/202311081028.yDLmCWgr-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311081028.yDLmCWgr-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/sched/core.c:6616:6: warning: no previous prototype for 'proxy_deactivate' [-Wmissing-prototypes]
    6616 | bool proxy_deactivate(struct rq *rq, struct task_struct *next)
         |      ^~~~~~~~~~~~~~~~


vim +/proxy_deactivate +6616 kernel/sched/core.c

  6615	
> 6616	bool proxy_deactivate(struct rq *rq, struct task_struct *next)
  6617	{
  6618		unsigned long state = READ_ONCE(next->__state);
  6619	
  6620		/* Don't deactivate if the state has been changed to TASK_RUNNING */
  6621		if (!state)
  6622			return false;
  6623		if (!try_to_deactivate_task(rq, next, state, true))
  6624			return false;
  6625		put_prev_task(rq, next);
  6626		rq_set_selected(rq, rq->idle);
  6627		resched_curr(rq);
  6628		return true;
  6629	}
  6630	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki