From: Arnd Bergmann <arnd@kernel.org>
To: Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Ayush Singh <ayushdevel1325@gmail.com>,
greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: [PATCH] greybus: beagleplay: select CONFIG_CRC_CCITT
Date: Wed, 8 Nov 2023 16:34:24 +0100 [thread overview]
Message-ID: <20231108153429.1072732-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
Without the CRC_CCITT code, the new greybus driver fails to link:
aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_append_tx_u8':
gb-beagleplay.c:(.text+0x158): undefined reference to `crc_ccitt'
aarch64-linux-ld: drivers/greybus/gb-beagleplay.o: in function `gb_tty_receive':
gb-beagleplay.c:(.text+0x5c4): undefined reference to `crc_ccitt'
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/greybus/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig
index 033d31dbf3b8..ab81ceceb337 100644
--- a/drivers/greybus/Kconfig
+++ b/drivers/greybus/Kconfig
@@ -20,6 +20,7 @@ if GREYBUS
config GREYBUS_BEAGLEPLAY
tristate "Greybus BeaglePlay driver"
depends on SERIAL_DEV_BUS
+ select CRC_CCITT
help
Select this option if you have a BeaglePlay where CC1352
co-processor acts as Greybus SVC.
--
2.39.2
next reply other threads:[~2023-11-08 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 15:34 Arnd Bergmann [this message]
2023-11-08 16:12 ` [PATCH] greybus: beagleplay: select CONFIG_CRC_CCITT Randy Dunlap
2023-11-08 16:25 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108153429.1072732-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=ayushdevel1325@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox