From: Al Viro <viro@zeniv.linux.org.uk>
To: WoZ1zh1 <wozizhi@huawei.com>
Cc: brauner@kernel.org, akpm@linux-foundation.org, oleg@redhat.com,
jlayton@kernel.org, dchinner@redhat.com, cyphar@cyphar.com,
shr@devkernel.io, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, yangerkun@huawei.com
Subject: Re: [PATCH -next V2] proc: support file->f_pos checking in mem_lseek
Date: Thu, 9 Nov 2023 02:40:23 +0000 [thread overview]
Message-ID: <20231109024023.GZ1957730@ZenIV> (raw)
In-Reply-To: <20231109102658.2075547-1-wozizhi@huawei.com>
On Thu, Nov 09, 2023 at 06:26:58PM +0800, WoZ1zh1 wrote:
> In mem_lseek, file->f_pos may overflow. And it's not a problem that
> mem_open set file mode with FMODE_UNSIGNED_OFFSET(memory_lseek). However,
> another file use mem_lseek do lseek can have not FMODE_UNSIGNED_OFFSET
> (kpageflags_proc_ops/proc_pagemap_operations...), so in order to prevent
> file->f_pos updated to an abnormal number, fix it by checking overflow and
> FMODE_UNSIGNED_OFFSET.
Umm... Is there any reasons why all of those shouldn't get FMODE_UNSIGNED_OFFSET
as well?
next prev parent reply other threads:[~2023-11-09 2:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 10:26 [PATCH -next V2] proc: support file->f_pos checking in mem_lseek WoZ1zh1
2023-11-09 2:40 ` Al Viro [this message]
2023-11-09 6:13 ` kernel test robot
2023-11-10 4:34 ` kernel test robot
2023-11-10 6:23 ` Zizhi Wo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109024023.GZ1957730@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=dchinner@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=shr@devkernel.io \
--cc=wozizhi@huawei.com \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox