From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CB83C4332F for ; Wed, 8 Nov 2023 22:33:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230426AbjKHWds (ORCPT ); Wed, 8 Nov 2023 17:33:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbjKHWdr (ORCPT ); Wed, 8 Nov 2023 17:33:47 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25129211B for ; Wed, 8 Nov 2023 14:33:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699482825; x=1731018825; h=date:from:to:cc:subject:message-id:mime-version; bh=U1SVjcAjCRbM5T3jWsqytreO2xyDEYxv08PP449oCWQ=; b=EgegKi+LcQvfCZW4MqjTKiJwkPhpNdSFWHK9x5UrteEpBHezZOi9ehKu Q5ZzTEPyZJ0n0cJT7/KedGImby8baa+w7kCVgKamWS8ZQd5H9f+iYGdUf XeijCyn1atfj39grMtw9gvkvV7ENXLRVoyein8Dlbs0xHhRw/0T4jmzWu r1BBOr0wv1oZxeVs1UMUqTv3O3Qo1S3QHRl/9mehBWAwQ7xLKHaRYS1QB tr1nUD2Lieax5+3xtdLVrE1ruFSc0CYZ6u0PSFZNKr78LnEkGc5iVoYQj AvmVRkagnN/aP/5RrOEKafZWzl7fjeg2UzJJNLTzN5g7uU5PPU8B2JRDx A==; X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="454172482" X-IronPort-AV: E=Sophos;i="6.03,287,1694761200"; d="scan'208";a="454172482" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2023 14:33:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="886800088" X-IronPort-AV: E=Sophos;i="6.03,287,1694761200"; d="scan'208";a="886800088" Received: from lkp-server01.sh.intel.com (HELO 17d9e85e5079) ([10.239.97.150]) by orsmga004.jf.intel.com with ESMTP; 08 Nov 2023 14:33:43 -0800 Received: from kbuild by 17d9e85e5079 with local (Exim 4.96) (envelope-from ) id 1r0r7E-0008Fg-2Q; Wed, 08 Nov 2023 22:33:40 +0000 Date: Thu, 9 Nov 2023 06:32:59 +0800 From: kernel test robot To: Kent Overstreet Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org Subject: fs/bcachefs/journal_io.c:1839 bch2_journal_write_pick_flush() warn: inconsistent indenting Message-ID: <202311090619.Ug0DltWc-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 90450a06162e6c71ab813ea22a83196fe7cff4bc commit: 80396a47490936f73729548310ad60e9f5df61c9 bcachefs: Break up bch2_journal_write() date: 3 days ago config: i386-randconfig-141-20231108 (https://download.01.org/0day-ci/archive/20231109/202311090619.Ug0DltWc-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: (https://download.01.org/0day-ci/archive/20231109/202311090619.Ug0DltWc-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202311090619.Ug0DltWc-lkp@intel.com/ New smatch warnings: fs/bcachefs/journal_io.c:1839 bch2_journal_write_pick_flush() warn: inconsistent indenting Old smatch warnings: fs/bcachefs/journal_io.c:132 journal_entry_add() warn: missing error code 'ret' vim +1839 fs/bcachefs/journal_io.c 1808 1809 static int bch2_journal_write_pick_flush(struct journal *j, struct journal_buf *w) 1810 { 1811 struct bch_fs *c = container_of(j, struct bch_fs, journal); 1812 int error = bch2_journal_error(j); 1813 1814 /* 1815 * If the journal is in an error state - we did an emergency shutdown - 1816 * we prefer to continue doing journal writes. We just mark them as 1817 * noflush so they'll never be used, but they'll still be visible by the 1818 * list_journal tool - this helps in debugging. 1819 * 1820 * There's a caveat: the first journal write after marking the 1821 * superblock dirty must always be a flush write, because on startup 1822 * from a clean shutdown we didn't necessarily read the journal and the 1823 * new journal write might overwrite whatever was in the journal 1824 * previously - we can't leave the journal without any flush writes in 1825 * it. 1826 * 1827 * So if we're in an error state, and we're still starting up, we don't 1828 * write anything at all. 1829 */ 1830 if (error && test_bit(JOURNAL_NEED_FLUSH_WRITE, &j->flags)) 1831 return -EIO; 1832 1833 if (error || 1834 w->noflush || 1835 (!w->must_flush && 1836 (jiffies - j->last_flush_write) < msecs_to_jiffies(c->opts.journal_flush_delay) && 1837 test_bit(JOURNAL_MAY_SKIP_FLUSH, &j->flags))) { 1838 w->noflush = true; > 1839 SET_JSET_NO_FLUSH(w->data, true); 1840 w->data->last_seq = 0; 1841 w->last_seq = 0; 1842 1843 j->nr_noflush_writes++; 1844 } else { 1845 j->last_flush_write = jiffies; 1846 j->nr_flush_writes++; 1847 clear_bit(JOURNAL_NEED_FLUSH_WRITE, &j->flags); 1848 } 1849 1850 return 0; 1851 } 1852 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki