From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 759AEC4332F for ; Thu, 9 Nov 2023 06:14:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232465AbjKIGOZ (ORCPT ); Thu, 9 Nov 2023 01:14:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229566AbjKIGOX (ORCPT ); Thu, 9 Nov 2023 01:14:23 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3150C2587; Wed, 8 Nov 2023 22:14:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699510461; x=1731046461; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lckBfTuMmgvgDrE6pOvFCArKZAwwbxnPo0ivG4mnKeo=; b=mEK8mvLRGYBD+VEMXIj3vOmab/GbTLImR6zU2MBKSY8k1HL0VZ0jz+4H u80R5okZjwmgM/kOVU0s4jtbY/qfvckv7MXSt0NCOo7izsGgeqM4Uhdcn T1WB5niSjXvWS14pmsXswHhuscEEnsLytxYiWJ3oe347/nFHg/THese3A BK/dBpMpnVTKAdUkAEjijwyYoHwHiOFfDNZzTvUzHU9Hm8zFGeRYjU3qi RedpKn52uPQcWOFNeN2YCQ3RDlFt72pZ7YAN5bIz5bIm8WAkTqMhbhqAO SiJE9ifdUWiDUJZ/zsOFkcB7E8lEGPq/C+9pd8Ldl44MeGqpQ/IucSBrT A==; X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="388779931" X-IronPort-AV: E=Sophos;i="6.03,288,1694761200"; d="scan'208";a="388779931" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2023 22:14:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,288,1694761200"; d="scan'208";a="11433456" Received: from lkp-server01.sh.intel.com (HELO 17d9e85e5079) ([10.239.97.150]) by fmviesa001.fm.intel.com with ESMTP; 08 Nov 2023 22:14:18 -0800 Received: from kbuild by 17d9e85e5079 with local (Exim 4.96) (envelope-from ) id 1r0yIx-0008WO-1i; Thu, 09 Nov 2023 06:14:15 +0000 Date: Thu, 9 Nov 2023 14:13:45 +0800 From: kernel test robot To: WoZ1zh1 , viro@zeniv.linux.org.uk, brauner@kernel.org, akpm@linux-foundation.org, oleg@redhat.com, jlayton@kernel.org, dchinner@redhat.com, cyphar@cyphar.com, shr@devkernel.io Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, wozizhi@huawei.com, yangerkun@huawei.com Subject: Re: [PATCH -next V2] proc: support file->f_pos checking in mem_lseek Message-ID: <202311091307.k2L6reDL-lkp@intel.com> References: <20231109102658.2075547-1-wozizhi@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231109102658.2075547-1-wozizhi@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi WoZ1zh1, kernel test robot noticed the following build warnings: [auto build test WARNING on next-20231108] url: https://github.com/intel-lab-lkp/linux/commits/WoZ1zh1/proc-support-file-f_pos-checking-in-mem_lseek/20231109-103353 base: next-20231108 patch link: https://lore.kernel.org/r/20231109102658.2075547-1-wozizhi%40huawei.com patch subject: [PATCH -next V2] proc: support file->f_pos checking in mem_lseek config: arc-randconfig-001-20231109 (https://download.01.org/0day-ci/archive/20231109/202311091307.k2L6reDL-lkp@intel.com/config) compiler: arc-elf-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231109/202311091307.k2L6reDL-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202311091307.k2L6reDL-lkp@intel.com/ All warnings (new ones prefixed by >>): fs/proc/base.c: In function 'mem_lseek': >> fs/proc/base.c:911:24: warning: this statement may fall through [-Wimplicit-fallthrough=] 911 | offset += file->f_pos; | ~~~~~~~^~~~~~~~~~~~~~ fs/proc/base.c:912:9: note: here 912 | case SEEK_SET: | ^~~~ vim +911 fs/proc/base.c 903 904 loff_t mem_lseek(struct file *file, loff_t offset, int orig) 905 { 906 loff_t ret = 0; 907 908 spin_lock(&file->f_lock); 909 switch (orig) { 910 case SEEK_CUR: > 911 offset += file->f_pos; 912 case SEEK_SET: 913 /* to avoid userland mistaking f_pos=-9 as -EBADF=-9 */ 914 if ((unsigned long long)offset >= -MAX_ERRNO) 915 ret = -EOVERFLOW; 916 break; 917 default: 918 ret = -EINVAL; 919 } 920 if (!ret) { 921 if (offset < 0 && !(unsigned_offsets(file))) { 922 ret = -EINVAL; 923 } else { 924 file->f_pos = offset; 925 ret = file->f_pos; 926 force_successful_syscall_return(); 927 } 928 } 929 930 spin_unlock(&file->f_lock); 931 return ret; 932 } 933 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki