* [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ
@ 2023-11-01 10:48 Ziqi Chen
2023-11-06 14:48 ` Rob Herring
2023-11-21 9:26 ` Krzysztof Kozlowski
0 siblings, 2 replies; 8+ messages in thread
From: Ziqi Chen @ 2023-11-01 10:48 UTC (permalink / raw)
To: quic_asutoshd, quic_cang, bvanassche, mani, beanhuo, avri.altman,
junwoo80.lee, martin.petersen, quic_ziqichen, quic_nguyenb,
quic_nitirawa, quic_rampraka
Cc: linux-scsi, Alim Akhtar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Ulf Hansson, Wolfram Sang, Guenter Roeck,
Miquel Raynal, Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
The Message Signaled Interrupts (MSI) has been introduced
to UFS driver since the MCQ be enabled. Hence in UFS DT
node we need to give the msi-parent property that point
to the hardware entity which serves as the MSI controller
for this UFS controller.
Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com>
---
Documentation/devicetree/bindings/ufs/ufs-common.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
index bbaee4f5..42309bb 100644
--- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
+++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
@@ -73,6 +73,8 @@ properties:
description:
Specifies max. load that can be drawn from VCCQ2 supply.
+ msi-parent: true
+
dependencies:
freq-table-hz: [ clocks ]
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-01 10:48 [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ Ziqi Chen
@ 2023-11-06 14:48 ` Rob Herring
2023-11-06 17:56 ` Bart Van Assche
2023-11-21 9:26 ` Krzysztof Kozlowski
1 sibling, 1 reply; 8+ messages in thread
From: Rob Herring @ 2023-11-06 14:48 UTC (permalink / raw)
To: Ziqi Chen
Cc: quic_asutoshd, quic_cang, bvanassche, mani, beanhuo, avri.altman,
junwoo80.lee, martin.petersen, quic_nguyenb, quic_nitirawa,
quic_rampraka, linux-scsi, Alim Akhtar, Krzysztof Kozlowski,
Conor Dooley, Ulf Hansson, Wolfram Sang, Guenter Roeck,
Miquel Raynal, Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Wed, Nov 01, 2023 at 06:48:13PM +0800, Ziqi Chen wrote:
> The Message Signaled Interrupts (MSI) has been introduced
> to UFS driver since the MCQ be enabled.
Not really relevant when a driver supported MSI, but the when the h/w
did. Has UFS always supported MSI? It was added in some version of the
spec?
> Hence in UFS DT
> node we need to give the msi-parent property that point
> to the hardware entity which serves as the MSI controller
> for this UFS controller.
>
> Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com>
> ---
> Documentation/devicetree/bindings/ufs/ufs-common.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> index bbaee4f5..42309bb 100644
> --- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> @@ -73,6 +73,8 @@ properties:
> description:
> Specifies max. load that can be drawn from VCCQ2 supply.
>
> + msi-parent: true
> +
> dependencies:
> freq-table-hz: [ clocks ]
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-06 14:48 ` Rob Herring
@ 2023-11-06 17:56 ` Bart Van Assche
2023-11-09 10:51 ` Ziqi Chen
2023-11-09 13:55 ` Rob Herring
0 siblings, 2 replies; 8+ messages in thread
From: Bart Van Assche @ 2023-11-06 17:56 UTC (permalink / raw)
To: Rob Herring, Ziqi Chen
Cc: quic_asutoshd, quic_cang, mani, beanhuo, avri.altman,
junwoo80.lee, martin.petersen, quic_nguyenb, quic_nitirawa,
quic_rampraka, linux-scsi, Alim Akhtar, Krzysztof Kozlowski,
Conor Dooley, Ulf Hansson, Wolfram Sang, Guenter Roeck,
Miquel Raynal, Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 11/6/23 06:48, Rob Herring wrote:
> On Wed, Nov 01, 2023 at 06:48:13PM +0800, Ziqi Chen wrote:
>> The Message Signaled Interrupts (MSI) has been introduced
>> to UFS driver since the MCQ be enabled.
>
> Not really relevant when a driver supported MSI, but the when the h/w
> did. Has UFS always supported MSI? It was added in some version of the
> spec?
MSI support has been introduced in UFSHCI version 4.0 and I think that
the controller vendor can decide whether or not to implement MSI. Does
this mean that the patch needs to be improved?
Thanks,
Bart.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-06 17:56 ` Bart Van Assche
@ 2023-11-09 10:51 ` Ziqi Chen
2023-11-09 13:55 ` Rob Herring
1 sibling, 0 replies; 8+ messages in thread
From: Ziqi Chen @ 2023-11-09 10:51 UTC (permalink / raw)
To: Bart Van Assche, Rob Herring
Cc: quic_asutoshd, quic_cang, mani, beanhuo, avri.altman,
junwoo80.lee, martin.petersen, quic_nguyenb, quic_nitirawa,
quic_rampraka, linux-scsi, Alim Akhtar, Krzysztof Kozlowski,
Conor Dooley, Ulf Hansson, Wolfram Sang, Guenter Roeck,
Miquel Raynal, Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 11/7/2023 1:56 AM, Bart Van Assche wrote:
> On 11/6/23 06:48, Rob Herring wrote:
>> On Wed, Nov 01, 2023 at 06:48:13PM +0800, Ziqi Chen wrote:
>>> The Message Signaled Interrupts (MSI) has been introduced
>>> to UFS driver since the MCQ be enabled.
>>
>> Not really relevant when a driver supported MSI, but the when the h/w
>> did. Has UFS always supported MSI? It was added in some version of the
>> spec?
>
> MSI support has been introduced in UFSHCI version 4.0 and I think that
> the controller vendor can decide whether or not to implement MSI. Does
> this mean that the patch needs to be improved?
>
> Thanks,
>
> Bart.
>
Hi Rob, in my previous patch " dt-bindings: ufs: qcom: Add msi-parent
for UFS MCQ", Manivannan Sadhasivam also think instead of
qcom,ufs.yaml, this should be part of ufs-common.yaml.
please let me know if there is any others I need to improve for this
patch. Thanks a lot.
Best Regards,
Ziqi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-06 17:56 ` Bart Van Assche
2023-11-09 10:51 ` Ziqi Chen
@ 2023-11-09 13:55 ` Rob Herring
2023-11-09 16:16 ` Manivannan Sadhasivam
1 sibling, 1 reply; 8+ messages in thread
From: Rob Herring @ 2023-11-09 13:55 UTC (permalink / raw)
To: Bart Van Assche
Cc: Ziqi Chen, quic_asutoshd, quic_cang, mani, beanhuo, avri.altman,
junwoo80.lee, martin.petersen, quic_nguyenb, quic_nitirawa,
quic_rampraka, linux-scsi, Alim Akhtar, Krzysztof Kozlowski,
Conor Dooley, Ulf Hansson, Wolfram Sang, Guenter Roeck,
Miquel Raynal, Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Mon, Nov 6, 2023 at 11:56 AM Bart Van Assche <bvanassche@acm.org> wrote:
>
> On 11/6/23 06:48, Rob Herring wrote:
> > On Wed, Nov 01, 2023 at 06:48:13PM +0800, Ziqi Chen wrote:
> >> The Message Signaled Interrupts (MSI) has been introduced
> >> to UFS driver since the MCQ be enabled.
> >
> > Not really relevant when a driver supported MSI, but the when the h/w
> > did. Has UFS always supported MSI? It was added in some version of the
> > spec?
>
> MSI support has been introduced in UFSHCI version 4.0 and I think that
> the controller vendor can decide whether or not to implement MSI. Does
> this mean that the patch needs to be improved?
Yes, this information is what should be in the commit msg rather than
driver details.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-09 13:55 ` Rob Herring
@ 2023-11-09 16:16 ` Manivannan Sadhasivam
2023-11-10 5:50 ` Ziqi Chen
0 siblings, 1 reply; 8+ messages in thread
From: Manivannan Sadhasivam @ 2023-11-09 16:16 UTC (permalink / raw)
To: Rob Herring
Cc: Bart Van Assche, Ziqi Chen, quic_asutoshd, quic_cang, beanhuo,
avri.altman, junwoo80.lee, martin.petersen, quic_nguyenb,
quic_nitirawa, quic_rampraka, linux-scsi, Alim Akhtar,
Krzysztof Kozlowski, Conor Dooley, Ulf Hansson, Wolfram Sang,
Guenter Roeck, Miquel Raynal, Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Thu, Nov 09, 2023 at 07:55:14AM -0600, Rob Herring wrote:
> On Mon, Nov 6, 2023 at 11:56 AM Bart Van Assche <bvanassche@acm.org> wrote:
> >
> > On 11/6/23 06:48, Rob Herring wrote:
> > > On Wed, Nov 01, 2023 at 06:48:13PM +0800, Ziqi Chen wrote:
> > >> The Message Signaled Interrupts (MSI) has been introduced
> > >> to UFS driver since the MCQ be enabled.
> > >
> > > Not really relevant when a driver supported MSI, but the when the h/w
> > > did. Has UFS always supported MSI? It was added in some version of the
> > > spec?
> >
> > MSI support has been introduced in UFSHCI version 4.0 and I think that
> > the controller vendor can decide whether or not to implement MSI. Does
> > this mean that the patch needs to be improved?
>
> Yes, this information is what should be in the commit msg rather than
> driver details.
>
Yes, agreed. Ziqi, please update the commit message to incorporate the hw
details about when MCQ/MSI got introduced. Devicetree binding should describe
the hw, not the driver.
- Mani
> Rob
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-09 16:16 ` Manivannan Sadhasivam
@ 2023-11-10 5:50 ` Ziqi Chen
0 siblings, 0 replies; 8+ messages in thread
From: Ziqi Chen @ 2023-11-10 5:50 UTC (permalink / raw)
To: Manivannan Sadhasivam, Rob Herring
Cc: Bart Van Assche, quic_asutoshd, quic_cang, beanhuo, avri.altman,
junwoo80.lee, martin.petersen, quic_nguyenb, quic_nitirawa,
quic_rampraka, linux-scsi, Alim Akhtar, Krzysztof Kozlowski,
Conor Dooley, Ulf Hansson, Wolfram Sang, Guenter Roeck,
Miquel Raynal, Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 11/10/2023 12:16 AM, Manivannan Sadhasivam wrote:
> On Thu, Nov 09, 2023 at 07:55:14AM -0600, Rob Herring wrote:
>> On Mon, Nov 6, 2023 at 11:56 AM Bart Van Assche <bvanassche@acm.org> wrote:
>>>
>>> On 11/6/23 06:48, Rob Herring wrote:
>>>> On Wed, Nov 01, 2023 at 06:48:13PM +0800, Ziqi Chen wrote:
>>>>> The Message Signaled Interrupts (MSI) has been introduced
>>>>> to UFS driver since the MCQ be enabled.
>>>>
>>>> Not really relevant when a driver supported MSI, but the when the h/w
>>>> did. Has UFS always supported MSI? It was added in some version of the
>>>> spec?
>>>
>>> MSI support has been introduced in UFSHCI version 4.0 and I think that
>>> the controller vendor can decide whether or not to implement MSI. Does
>>> this mean that the patch needs to be improved?
>>
>> Yes, this information is what should be in the commit msg rather than
>> driver details.
>>
>
> Yes, agreed. Ziqi, please update the commit message to incorporate the hw
> details about when MCQ/MSI got introduced. Devicetree binding should describe
> the hw, not the driver.
>
Thank you all, I will update the commit message in next version.
- Ziqi
> - Mani
>
>> Rob
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-01 10:48 [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ Ziqi Chen
2023-11-06 14:48 ` Rob Herring
@ 2023-11-21 9:26 ` Krzysztof Kozlowski
1 sibling, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-21 9:26 UTC (permalink / raw)
To: Ziqi Chen, quic_asutoshd, quic_cang, bvanassche, mani, beanhuo,
avri.altman, junwoo80.lee, martin.petersen, quic_nguyenb,
quic_nitirawa, quic_rampraka
Cc: linux-scsi, Alim Akhtar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Ulf Hansson, Wolfram Sang, Guenter Roeck,
Miquel Raynal, Mark Brown,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 01/11/2023 11:48, Ziqi Chen wrote:
> The Message Signaled Interrupts (MSI) has been introduced
> to UFS driver since the MCQ be enabled. Hence in UFS DT
> node we need to give the msi-parent property that point
> to the hardware entity which serves as the MSI controller
> for this UFS controller.
>
> Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com>
Which tree or next did you use as base for this patch? It does not
apply, neither on October's next nor on current. It does not apply on
v6.7-rc1 either...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-11-21 9:27 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-01 10:48 [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ Ziqi Chen
2023-11-06 14:48 ` Rob Herring
2023-11-06 17:56 ` Bart Van Assche
2023-11-09 10:51 ` Ziqi Chen
2023-11-09 13:55 ` Rob Herring
2023-11-09 16:16 ` Manivannan Sadhasivam
2023-11-10 5:50 ` Ziqi Chen
2023-11-21 9:26 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox