From: Al Viro <viro@zeniv.linux.org.uk>
To: Zizhi Wo <wozizhi@huawei.com>
Cc: brauner@kernel.org, akpm@linux-foundation.org, oleg@redhat.com,
jlayton@kernel.org, dchinner@redhat.com, adobriyan@gmail.com,
yang.lee@linux.alibaba.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, yangerkun@huawei.com
Subject: Re: [PATCH next V3] proc: support file->f_pos checking in mem_lseek
Date: Fri, 10 Nov 2023 08:21:11 +0000 [thread overview]
Message-ID: <20231110082111.GN1957730@ZenIV> (raw)
In-Reply-To: <20231110151928.2667204-1-wozizhi@huawei.com>
On Fri, Nov 10, 2023 at 11:19:28PM +0800, Zizhi Wo wrote:
> From: WoZ1zh1 <wozizhi@huawei.com>
>
> In mem_lseek, file->f_pos may overflow. And it's not a problem that
> mem_open set file mode with FMODE_UNSIGNED_OFFSET(memory_lseek). However,
> another file use mem_lseek do lseek can have not FMODE_UNSIGNED_OFFSET
> (kpageflags_proc_ops/proc_pagemap_operations...), so in order to prevent
> file->f_pos updated to an abnormal number, fix it by checking overflow and
> FMODE_UNSIGNED_OFFSET.
1) How is that different from the previous version?
2) Would FMODE_UNSIGNED_OFFSET be wrong for those files? If not, why not?
next prev parent reply other threads:[~2023-11-10 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 15:19 [PATCH next V3] proc: support file->f_pos checking in mem_lseek Zizhi Wo
2023-11-10 8:21 ` Al Viro [this message]
2023-11-10 8:30 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110082111.GN1957730@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=dchinner@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=wozizhi@huawei.com \
--cc=yang.lee@linux.alibaba.com \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox