From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C48BAC4167D for ; Fri, 10 Nov 2023 20:12:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345968AbjKJUMc (ORCPT ); Fri, 10 Nov 2023 15:12:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344735AbjKJUMb (ORCPT ); Fri, 10 Nov 2023 15:12:31 -0500 Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D464A9; Fri, 10 Nov 2023 12:12:27 -0800 (PST) Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-1efabc436e4so1278547fac.1; Fri, 10 Nov 2023 12:12:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699647146; x=1700251946; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aYPa4O78Tl9tcmK397HC2WttsKjZOddgN547MJ4MmL0=; b=OhS+YDKKYTq/d/EIv64xE31/aQrRpe+f5e6nJJ/BUQZhSPgCqc1299mvURN5OCDjJG 1xONDYvCqxpK3+8UcghUfSfEVV7zAUkxOILmYSz68s3PpU63cNX61YpttMssvrMH9oeg Xs5/4+iipR7e+1GmPBCmKwHxjAdE7Z2FgMdKz7rr2e2F+c248UTDylajYBooOCeUU1gN mV96/8AI01uS/+mb/2xX2ZWUG9gjqsLabQCRyHJiC6NoKYHQgzwq/4fuOjre1EGtIla2 3kh/LEcubORxxcwqiGduIReWUWp7Cxblr5cJ1xrmCGENjzhMF28L1VPIBBVu0fjn0SgH dChw== X-Gm-Message-State: AOJu0YwVYiiJrpq4KTf57154O0OmPnHGl516tjFYBeVynmJ67S5PEJM1 SQQrkSzmDuoLP0p4Sny0qg== X-Google-Smtp-Source: AGHT+IGGXIL2O/re8npp6ti2/LlN+F5Sn3lm88DX439xHtC4GKBD8xBJhNWXN6GHMCBpDIWH4xG5Rw== X-Received: by 2002:a05:6870:2dc6:b0:1c8:c27f:7d9b with SMTP id op6-20020a0568702dc600b001c8c27f7d9bmr282410oab.27.1699647146338; Fri, 10 Nov 2023 12:12:26 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id y22-20020a056870725600b001ea4324364csm52458oaf.12.2023.11.10.12.12.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 12:12:25 -0800 (PST) Received: (nullmailer pid 351692 invoked by uid 1000); Fri, 10 Nov 2023 20:12:23 -0000 Date: Fri, 10 Nov 2023 14:12:23 -0600 From: Rob Herring To: Neil Armstrong Cc: Jerome Brunet , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Martin Blumenstingl , David Airlie , Daniel Vetter , Jagan Teki , Nicolas Belin , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v8 02/12] dt-bindings: soc: amlogic,meson-gx-hhi-sysctrl: add example covering meson-axg-hhi-sysctrl Message-ID: <20231110201223.GA347493-robh@kernel.org> References: <20231109-amlogic-v6-4-upstream-dsi-ccf-vim3-v8-0-81e4aeeda193@linaro.org> <20231109-amlogic-v6-4-upstream-dsi-ccf-vim3-v8-2-81e4aeeda193@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231109-amlogic-v6-4-upstream-dsi-ccf-vim3-v8-2-81e4aeeda193@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 09, 2023 at 10:00:03AM +0100, Neil Armstrong wrote: > Add a thirst example covering the meson-axg-hhi-sysctrl variant and more > importantly the phy subnode. > > Signed-off-by: Neil Armstrong > --- > .../soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml | 41 ++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml > index 16977e4e4357..2edf4ccea845 100644 > --- a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml > +++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml > @@ -158,3 +158,44 @@ examples: > }; > }; > }; > + New example should be separate starting with a '-|'. > + bus@ff63c000 { > + compatible = "simple-bus"; > + reg = <0xff63c000 0x1c00>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0xff63c000 0x1c00>; Why do you need all this? 1 cell is the default for examples. > + > + system-controller@0 { > + compatible = "amlogic,meson-axg-hhi-sysctrl", "simple-mfd", "syscon"; > + reg = <0 0x400>; > + > + clock-controller { > + compatible = "amlogic,axg-clkc"; > + #clock-cells = <1>; > + clocks = <&xtal>; > + clock-names = "xtal"; > + }; > + > + power-controller { > + compatible = "amlogic,meson-axg-pwrc"; > + #power-domain-cells = <1>; > + amlogic,ao-sysctrl = <&sysctrl_AO>; > + > + resets = <&reset_viu>, > + <&reset_venc>, > + <&reset_vcbus>, > + <&reset_vencl>, > + <&reset_vid_lock>; > + reset-names = "viu", "venc", "vcbus", "vencl", "vid_lock"; > + clocks = <&clk_vpu>, <&clk_vapb>; > + clock-names = "vpu", "vapb"; > + }; > + > + phy { > + compatible = "amlogic,axg-mipi-pcie-analog-phy"; > + #phy-cells = <0>; > + status = "disabled"; Examples should not be disabled. > + }; > + }; > + }; > > -- > 2.34.1 >