Re: [PATCH v2 net 4/7] net/sched: taprio: get corrected value of cycle_time and interval

kernel test robot
2023-11-07T22:46:55Z

Hi Faizal,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net/main]

url: https://github.com/intel-lab-lkp/linux/commits/Faizal-Rahim/net-sched-taprio-fix-too-early-schedules-switching/20231107-192843
base: net/main
patch link: https://lore.kernel.org/r/20231107112023.676016-5-faizal.abdul.rahim%40linux.intel.com
patch subject: [PATCH v2 net 4/7] net/sched: taprio: get corrected value of cycle_time and interval
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20231108/202311080506.qMlPx2WA-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231108/202311080506.qMlPx2WA-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311080506.qMlPx2WA-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/sched/sch_taprio.c:227:5: warning: no previous prototype for 'get_interval' [-Wmissing-prototypes]
227 | u32 get_interval(const struct sched_entry *entry,
| ^~~~~~~~~~~~
>> net/sched/sch_taprio.c:236:5: warning: no previous prototype for 'get_cycle_time' [-Wmissing-prototypes]
236 | s64 get_cycle_time(const struct sched_gate_list *oper)
| ^~~~~~~~~~~~~~

vim +/get_interval +227 net/sched/sch_taprio.c

226
> 227 u32 get_interval(const struct sched_entry *entry,
228 const struct sched_gate_list *oper)
229 {
230 if (entry->correction_active)
231 return entry->interval + oper->cycle_time_correction;
232 else
233 return entry->interval;
234 }
235
> 236 s64 get_cycle_time(const struct sched_gate_list *oper)
237 {
238 if (cycle_corr_active(oper->cycle_time_correction))
239 return oper->cycle_time + oper->cycle_time_correction;
240 else
241 return oper->cycle_time;
242 }
243

--
0-DAY CI Kernel Test Service