From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07F33C4332F for ; Sun, 12 Nov 2023 13:31:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232097AbjKLNbV (ORCPT ); Sun, 12 Nov 2023 08:31:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232614AbjKLNaS (ORCPT ); Sun, 12 Nov 2023 08:30:18 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AA4E49E4; Sun, 12 Nov 2023 05:29:00 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8386C433C9; Sun, 12 Nov 2023 13:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699795740; bh=8GGQ5f9ftAw5kvq9oFlMaEXzoI12Sb3RwcqfpztGaPM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qCxvUHSvqWiBuBLwS3DdbtcyzejpxyQaOAWcZOOC+FE2rjffg0fEgDM4dlXD++ONq X+gO0g50nxYRxmqUesFi3Dazh24uEja60cFR12Jgf/DPDkQsOpqkWaq1uY0o1YVMLL SJLETTB0w0z160ZmB183dVZ0+xsp/t4qng1u9KW6DPAG76xocoT5Nu5Y8rBSkDnuAo sF0A1h9kRBFt7vlBeYjAObPU5qsAQiyMV2mspACal5ZcJYo4VEz5SckWmNRZOOeep2 mQI+9fUeEOfeaOK6puFGsYTu/E+AACQZZL5cGVqNZIJFXvg0YsAbmGDgX+n9KCOhUK ODLvV+FJhQnKg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wayne Lin , Jun Lei , Hersen Wu , Daniel Wheeler , Alex Deucher , Sasha Levin , christian.koenig@amd.com, airlied@linux.ie, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.10 8/8] drm/amd/display: Avoid NULL dereference of timing generator Date: Sun, 12 Nov 2023 08:28:46 -0500 Message-ID: <20231112132847.176473-8-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231112132847.176473-1-sashal@kernel.org> References: <20231112132847.176473-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.200 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wayne Lin [ Upstream commit b1904ed480cee3f9f4036ea0e36d139cb5fee2d6 ] [Why & How] Check whether assigned timing generator is NULL or not before accessing its funcs to prevent NULL dereference. Reviewed-by: Jun Lei Acked-by: Hersen Wu Signed-off-by: Wayne Lin Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c index d48fd87d3b953..8206c6edba746 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c @@ -534,7 +534,7 @@ uint32_t dc_stream_get_vblank_counter(const struct dc_stream_state *stream) for (i = 0; i < MAX_PIPES; i++) { struct timing_generator *tg = res_ctx->pipe_ctx[i].stream_res.tg; - if (res_ctx->pipe_ctx[i].stream != stream) + if (res_ctx->pipe_ctx[i].stream != stream || !tg) continue; return tg->funcs->get_frame_count(tg); @@ -593,7 +593,7 @@ bool dc_stream_get_scanoutpos(const struct dc_stream_state *stream, for (i = 0; i < MAX_PIPES; i++) { struct timing_generator *tg = res_ctx->pipe_ctx[i].stream_res.tg; - if (res_ctx->pipe_ctx[i].stream != stream) + if (res_ctx->pipe_ctx[i].stream != stream || !tg) continue; tg->funcs->get_scanoutpos(tg, -- 2.42.0