From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5BBBC4332F for ; Mon, 13 Nov 2023 13:18:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230469AbjKMNS6 (ORCPT ); Mon, 13 Nov 2023 08:18:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230470AbjKMNS4 (ORCPT ); Mon, 13 Nov 2023 08:18:56 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A19BD6F for ; Mon, 13 Nov 2023 05:18:53 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D4BEC433C8; Mon, 13 Nov 2023 13:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699881533; bh=+8leGFcBO03KqBvuLccS/eEH1Cx5hybO9OKnutzXe8I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UNhek2gP1BRQnDnH2LeNK6SUvXBliiLONnJ+7GEWmYH3qrA54djm4qU20qX0ZSgC9 VSAZQZFtU1s9R7YMJnyPIt9cPd8r65omFzblmWhyJbY7YvZfys1aHaClOHDyIhbRtj yssTaeVhe//MlV/hHXAY5hnNYfBYJUhLF6aiDfANMxVfcEFPu5F5qSXzh/9vtj5/D2 0z7c2BtEbFw/JTIJgix595Z2zRsgrh/bw+R31NegCromIEO3yxYPQxIuOn3TVRR/eU JSj9v0Fot4yiy7yh8HZD6dD0kDGIhohRo0mGogfIdCZTfIhS1GC35nFZMwc3Omuet8 RX9cUepEDUsZQ== Date: Mon, 13 Nov 2023 13:18:49 +0000 From: Conor Dooley To: Inochi Amaoto Cc: Guo Ren , Jisheng Zhang , Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Chen Wang , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 1/2] dt-bindings: timer: thead,c900-aclint-mtimer: separate mtime and mtimecmp regs Message-ID: <20231113-confusing-postcard-7dd9da33dc23@squawk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CBvT2rAjqEdWny82" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --CBvT2rAjqEdWny82 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 13, 2023 at 10:23:59AM +0800, Inochi Amaoto wrote: > To make thead aclint timer more closer to the aclint spec, use two regs > to represent the mtime and mtimecmp. In the devicetree patch you say: "Change the timer layout in the dtb to fit the format that needed by the SBI." That seems like a far more important thing to say in the binding patch, since that is where the ABI is set. You also provide two links to discussion on the mailing list for opensbi, but provide no context in the commit message here for why they're relevant. The 005738 one doesn't seem to be relevant at all? Could you please resubmit this with a better commit message that explains why the ABI here needs to change? Thanks, Conor. >=20 > Signed-off-by: Inochi Amaoto > Fixes: 4734449f7311 ("dt-bindings: timer: Add Sophgo sg2042 CLINT timer") > Link: https://lists.infradead.org/pipermail/opensbi/2023-October/005693.h= tml > Link: https://lists.infradead.org/pipermail/opensbi/2023-October/005738.h= tml > Link: https://github.com/riscv/riscv-aclint/blob/main/riscv-aclint.adoc > --- > .../devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/timer/thead,c900-aclint-mt= imer.yaml b/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtime= r.yaml > index fbd235650e52..c3080962d902 100644 > --- a/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.ya= ml > +++ b/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.ya= ml > @@ -17,7 +17,7 @@ properties: > - const: thead,c900-aclint-mtimer >=20 > reg: > - maxItems: 1 > + maxItems: 2 >=20 > interrupts-extended: > minItems: 1 > @@ -38,6 +38,7 @@ examples: > <&cpu2intc 7>, > <&cpu3intc 7>, > <&cpu4intc 7>; > - reg =3D <0xac000000 0x00010000>; > + reg =3D <0xac000000 0x00000000>, > + <0xac000000 0x0000c000>; > }; > ... > -- > 2.42.1 >=20 --CBvT2rAjqEdWny82 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZVIiNgAKCRB4tDGHoIJi 0h83AQCPCDghV0IzJbJmjexiHOifjtNURzlkEKw1HzXGmn/tGwD8CBvuwPYjE8yD nJPH05dSoYXOM+TkZ2ZJ2jjLLfJIygg= =SBI8 -----END PGP SIGNATURE----- --CBvT2rAjqEdWny82--