From: "Krzysztof Wilczyński" <kw@linux.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Xiaowei Song <songxiaowei@hisilicon.com>,
Binghui Wang <wangbinghui@hisilicon.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: kirin: Use devm_kasprintf()
Date: Mon, 13 Nov 2023 18:55:57 +0900 [thread overview]
Message-ID: <20231113095557.GA1583963@rocinante> (raw)
In-Reply-To: <085fc5ac70fc8d73d5da197967e76d18f2ab5208.1699774592.git.christophe.jaillet@wanadoo.fr>
Hello!
[...]
> @@ -387,9 +386,8 @@ static int kirin_pcie_get_gpio_enable(struct kirin_pcie *pcie,
> if (pcie->gpio_id_clkreq[i] < 0)
> return pcie->gpio_id_clkreq[i];
>
> - sprintf(name, "pcie_clkreq_%d", i);
> - pcie->clkreq_names[i] = devm_kstrdup_const(dev, name,
> - GFP_KERNEL);
> + pcie->clkreq_names[i] = devm_kasprintf(dev, GFP_KERNEL,
> + "pcie_clkreq_%d", i);
I think, the kirin_pcie_parse_port(), which is just below form this
function, might benefit from the same type of a nice change. Thoughts?
Krzysztof
next prev parent reply other threads:[~2023-11-13 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 7:37 [PATCH] PCI: kirin: Use devm_kasprintf() Christophe JAILLET
2023-11-13 9:30 ` Serge Semin
2023-11-13 9:55 ` Krzysztof Wilczyński [this message]
2023-11-13 19:13 ` Christophe JAILLET
2023-11-14 13:06 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231113095557.GA1583963@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
--cc=songxiaowei@hisilicon.com \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox