From: Jakub Kicinski <kuba@kernel.org>
To: <mchan@broadcom.com>
Cc: <alexey.pakhunov@spacex.com>, <vincent.wong2@spacex.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<siva.kallam@broadcom.com>, <prashant@broadcom.com>
Subject: Re: [PATCH v4 1/2] tg3: Move the [rt]x_dropped counters to tg3_napi
Date: Mon, 13 Nov 2023 17:38:30 -0500 [thread overview]
Message-ID: <20231113173830.4c01d551@kernel.org> (raw)
In-Reply-To: <20231113182350.37472-1-alexey.pakhunov@spacex.com>
On Mon, 13 Nov 2023 10:23:49 -0800 alexey.pakhunov@spacex.com wrote:
> This change moves [rt]x_dropped counters to tg3_napi so that they can be
> updated by a single writer, race-free.
Michael, do you have a preference on the using u64_stats_inc() ?
Since we're only doing inc here the conversion should be pretty
trivial. The semantics of local64 are a bit murky but looks like
other drivers think that it's okay to use inc without
u64_stats_update_begin() / end().
next prev parent reply other threads:[~2023-11-13 22:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 18:23 [PATCH v4 1/2] tg3: Move the [rt]x_dropped counters to tg3_napi alexey.pakhunov
2023-11-13 18:23 ` [PATCH v4 2/2] tg3: Increment tx_dropped in tg3_tso_bug() alexey.pakhunov
2023-11-14 10:06 ` Pavan Chebbi
2023-11-13 22:38 ` Jakub Kicinski [this message]
2023-11-13 23:19 ` [PATCH v4 1/2] tg3: Move the [rt]x_dropped counters to tg3_napi Michael Chan
2023-11-15 4:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231113173830.4c01d551@kernel.org \
--to=kuba@kernel.org \
--cc=alexey.pakhunov@spacex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
--cc=siva.kallam@broadcom.com \
--cc=vincent.wong2@spacex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox