* [PATCH][next] thunderbolt: remove duplicated re-assignment of pointer 'out'
@ 2023-11-11 20:15 Colin Ian King
2023-11-14 12:22 ` Mika Westerberg
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2023-11-11 20:15 UTC (permalink / raw)
To: Andreas Noever, Michael Jamet, Mika Westerberg, Yehezkel Bernat,
linux-usb
Cc: kernel-janitors, linux-kernel
The pointer 'out' is initialized and then a few statments later being
re-assigned the same value. The second re-assignment is redundant and
can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/thunderbolt/tunnel.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/thunderbolt/tunnel.c b/drivers/thunderbolt/tunnel.c
index 7534cd3a81f4..8d45cb4f04ab 100644
--- a/drivers/thunderbolt/tunnel.c
+++ b/drivers/thunderbolt/tunnel.c
@@ -1313,8 +1313,6 @@ static void tb_dp_dump(struct tb_tunnel *tunnel)
"DP IN maximum supported bandwidth %u Mb/s x%u = %u Mb/s\n",
rate, lanes, tb_dp_bandwidth(rate, lanes));
- out = tunnel->dst_port;
-
if (tb_port_read(out, &dp_cap, TB_CFG_PORT,
out->cap_adap + DP_LOCAL_CAP, 1))
return;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] thunderbolt: remove duplicated re-assignment of pointer 'out'
2023-11-11 20:15 [PATCH][next] thunderbolt: remove duplicated re-assignment of pointer 'out' Colin Ian King
@ 2023-11-14 12:22 ` Mika Westerberg
0 siblings, 0 replies; 2+ messages in thread
From: Mika Westerberg @ 2023-11-14 12:22 UTC (permalink / raw)
To: Colin Ian King
Cc: Andreas Noever, Michael Jamet, Yehezkel Bernat, linux-usb,
kernel-janitors, linux-kernel
On Sat, Nov 11, 2023 at 08:15:43PM +0000, Colin Ian King wrote:
> The pointer 'out' is initialized and then a few statments later being
> re-assigned the same value. The second re-assignment is redundant and
> can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Applied to thunderbolt.git/next, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-14 12:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-11 20:15 [PATCH][next] thunderbolt: remove duplicated re-assignment of pointer 'out' Colin Ian King
2023-11-14 12:22 ` Mika Westerberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox