From: kernel test robot <yujie.liu@intel.com>
To: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: <oe-kbuild-all@lists.linux.dev>,
Ji Sheng Teoh <jisheng.teoh@starfivetech.com>,
Ley Foon Tan <leyfoon.tan@starfivetech.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] perf: starfive: Add StarLink PMU support
Date: Wed, 15 Nov 2023 10:02:40 +0800 [thread overview]
Message-ID: <202311142041.nSLDeqju-lkp@intel.com> (raw)
In-Reply-To: <20231114021254.3009799-2-jisheng.teoh@starfivetech.com>
Hi Ji,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on arm-perf/for-next/perf tip/smp/core linus/master v6.7-rc1 next-20231114]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ji-Sheng-Teoh/perf-starfive-Add-StarLink-PMU-support/20231114-101811
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20231114021254.3009799-2-jisheng.teoh%40starfivetech.com
patch subject: [PATCH v2 1/2] perf: starfive: Add StarLink PMU support
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20231114/202311142041.nSLDeqju-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231114/202311142041.nSLDeqju-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <yujie.liu@intel.com>
| Closes: https://lore.kernel.org/r/202311142041.nSLDeqju-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/perf/starfive_starlink_pmu.c:158:6: warning: no previous prototype for 'starlink_pmu_set_event_period' [-Wmissing-prototypes]
158 | void starlink_pmu_set_event_period(struct perf_event *event)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/starlink_pmu_set_event_period +158 drivers/perf/starfive_starlink_pmu.c
cff226048d4861 Ji Sheng Teoh 2023-11-14 157
cff226048d4861 Ji Sheng Teoh 2023-11-14 @158 void starlink_pmu_set_event_period(struct perf_event *event)
cff226048d4861 Ji Sheng Teoh 2023-11-14 159 {
cff226048d4861 Ji Sheng Teoh 2023-11-14 160 struct starlink_pmu *starlink_pmu = to_starlink_pmu(event->pmu);
cff226048d4861 Ji Sheng Teoh 2023-11-14 161 struct hw_perf_event *hwc = &event->hw;
cff226048d4861 Ji Sheng Teoh 2023-11-14 162 int idx = event->hw.idx;
cff226048d4861 Ji Sheng Teoh 2023-11-14 163
cff226048d4861 Ji Sheng Teoh 2023-11-14 164 /*
cff226048d4861 Ji Sheng Teoh 2023-11-14 165 * Program counter to half of it's max count to handle
cff226048d4861 Ji Sheng Teoh 2023-11-14 166 * cases of extreme interrupt latency.
cff226048d4861 Ji Sheng Teoh 2023-11-14 167 */
cff226048d4861 Ji Sheng Teoh 2023-11-14 168 u64 val = STARLINK_PMU_COUNTER_MASK >> 1;
cff226048d4861 Ji Sheng Teoh 2023-11-14 169
cff226048d4861 Ji Sheng Teoh 2023-11-14 170 local64_set(&hwc->prev_count, val);
cff226048d4861 Ji Sheng Teoh 2023-11-14 171 if (hwc->config == CYCLES)
cff226048d4861 Ji Sheng Teoh 2023-11-14 172 writeq(val, starlink_pmu->pmu_base + STARLINK_PMU_CYCLE_COUNTER);
cff226048d4861 Ji Sheng Teoh 2023-11-14 173 else
cff226048d4861 Ji Sheng Teoh 2023-11-14 174 writeq(val, starlink_pmu->pmu_base + STARLINK_PMU_EVENT_COUNTER +
cff226048d4861 Ji Sheng Teoh 2023-11-14 175 idx * sizeof(u64));
cff226048d4861 Ji Sheng Teoh 2023-11-14 176 }
cff226048d4861 Ji Sheng Teoh 2023-11-14 177
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-11-15 2:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 2:12 [PATCH v2 0/2] StarFive's StarLink PMU Support Ji Sheng Teoh
2023-11-14 2:12 ` [PATCH v2 1/2] perf: starfive: Add StarLink PMU support Ji Sheng Teoh
2023-11-15 2:02 ` kernel test robot [this message]
2023-11-14 2:12 ` [PATCH v2 2/2] dt-bindings: perf: starfive: Add StarLink PMU Ji Sheng Teoh
2023-11-14 17:57 ` Conor Dooley
2023-11-15 2:57 ` Ji Sheng Teoh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202311142041.nSLDeqju-lkp@intel.com \
--to=yujie.liu@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jisheng.teoh@starfivetech.com \
--cc=krzk@kernel.org \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox