Re: [PATCH v2 2/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

Dmitry Baryshkov
2023-11-15T07:27:07Z

On Wed, 15 Nov 2023 at 01:00, Jonathan Marek <jonathan@marek.ca> wrote:
>
> The value returned by msm_dsi_wide_bus_enabled() doesn't match what the
> driver is doing in video mode. Fix that by actually enabling widebus for
> video mode.
>
> Fixes: efcbd6f9cdeb ("drm/msm/dsi: Enable widebus for DSI")
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
> drivers/gpu/drm/msm/dsi/dsi.xml.h | 1 +
> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi.xml.h b/drivers/gpu/drm/msm/dsi/dsi.xml.h
> index 2a7d980e12c3..f0b3cdc020a1 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi.xml.h
> +++ b/drivers/gpu/drm/msm/dsi/dsi.xml.h
> @@ -231,6 +231,7 @@ static inline uint32_t DSI_VID_CFG0_TRAFFIC_MODE(enum dsi_traffic_mode val)
> #define DSI_VID_CFG0_HSA_POWER_STOP 0x00010000
> #define DSI_VID_CFG0_HBP_POWER_STOP 0x00100000
> #define DSI_VID_CFG0_HFP_POWER_STOP 0x01000000
> +#define DSI_VID_CFG0_DATABUS_WIDEN 0x02000000

BTW, could you please push this register to mesa?

> #define DSI_VID_CFG0_PULSE_MODE_HSA_HE 0x10000000
>
> #define REG_DSI_VID_CFG1 0x0000001c

--
With best wishes
Dmitry