From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1842DC07548 for ; Wed, 15 Nov 2023 03:42:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234536AbjKODm1 (ORCPT ); Tue, 14 Nov 2023 22:42:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234537AbjKODmJ (ORCPT ); Tue, 14 Nov 2023 22:42:09 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB767D6A; Tue, 14 Nov 2023 19:41:53 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 043A4C433C9; Wed, 15 Nov 2023 03:41:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700019713; bh=5ugMHOr9wHAuOpz+XLNUnUJVJrQu07HHSATh2KaJVy0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HlbPP06qMOH9dWKu+tolpF2kYFbHkYSxfBlPSuTfJSsPp9JB+jqsWGtDHxe9qhrTv Gq5yp113IytFXhWSV8fenpw3EMc3Wl1WBhkatKZw1e8HBa1kfnfYJ33Kg8ATNYnoVb DOCiNg1eLf2rKVKHv8vV5iTMJ9fLnmSNo5rR5RwVInPfjPTkMbYxlbwZ3hCngNEvRr 7lKa5FD2Tuz5sBUknfpfuQKW35rX/WV7k8o/XCstVYqsAOqhrLNSK/IL0ZZYkcflc2 EhYp7hVM7pRE27lek9Bknh9ro+ItlL/cDbG80/SMEkYPZhd//ilmyMptyWTANAHH/J WPVj/fRsNfYYw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Sam Protsenko , Thierry Reding , Sasha Levin , linux-pwm@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 3/3] pwm: Fix double shift bug Date: Tue, 14 Nov 2023 22:41:14 -0500 Message-ID: <20231115034123.1239405-3-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231115034123.1239405-1-sashal@kernel.org> References: <20231115034123.1239405-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.200 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit d27abbfd4888d79dd24baf50e774631046ac4732 ] These enums are passed to set/test_bit(). The set/test_bit() functions take a bit number instead of a shifted value. Passing a shifted value is a double shift bug like doing BIT(BIT(1)). The double shift bug doesn't cause a problem here because we are only checking 0 and 1 but if the value was 5 or above then it can lead to a buffer overflow. Signed-off-by: Dan Carpenter Reviewed-by: Uwe Kleine-König Reviewed-by: Sam Protsenko Signed-off-by: Thierry Reding Signed-off-by: Sasha Levin --- include/linux/pwm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/pwm.h b/include/linux/pwm.h index a13ff383fa1d5..c0cf6613373f9 100644 --- a/include/linux/pwm.h +++ b/include/linux/pwm.h @@ -44,8 +44,8 @@ struct pwm_args { }; enum { - PWMF_REQUESTED = 1 << 0, - PWMF_EXPORTED = 1 << 1, + PWMF_REQUESTED = 0, + PWMF_EXPORTED = 1, }; /* -- 2.42.0