From: Cruz Zhao <CruzZhao@linux.alibaba.com>
To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com, joel@joelfernandes.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] sched/core: introduce core_id to struct rq
Date: Wed, 15 Nov 2023 19:33:38 +0800 [thread overview]
Message-ID: <20231115113341.13261-2-CruzZhao@linux.alibaba.com> (raw)
In-Reply-To: <20231115113341.13261-1-CruzZhao@linux.alibaba.com>
Introduce core_id to struct rq, indates the cpu id of the core, which
is used for getting cpu id of rq->core quickly.
Signed-off-by: Cruz Zhao <CruzZhao@linux.alibaba.com>
---
kernel/sched/core.c | 16 ++++++++++++----
kernel/sched/sched.h | 1 +
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index a708d225c28e..7a685fae73c4 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6400,7 +6400,7 @@ static void sched_core_cpu_starting(unsigned int cpu)
{
const struct cpumask *smt_mask = cpu_smt_mask(cpu);
struct rq *rq = cpu_rq(cpu), *core_rq = NULL;
- int t;
+ int t, core_id;
guard(core_lock)(&cpu);
@@ -6417,6 +6417,7 @@ static void sched_core_cpu_starting(unsigned int cpu)
rq = cpu_rq(t);
if (rq->core == rq) {
core_rq = rq;
+ core_id = t;
break;
}
}
@@ -6428,8 +6429,10 @@ static void sched_core_cpu_starting(unsigned int cpu)
for_each_cpu(t, smt_mask) {
rq = cpu_rq(t);
- if (t == cpu)
+ if (t == cpu) {
rq->core = core_rq;
+ rq->core_id = core_id;
+ }
WARN_ON_ONCE(rq->core != core_rq);
}
@@ -6439,7 +6442,7 @@ static void sched_core_cpu_deactivate(unsigned int cpu)
{
const struct cpumask *smt_mask = cpu_smt_mask(cpu);
struct rq *rq = cpu_rq(cpu), *core_rq = NULL;
- int t;
+ int t, core_id;
guard(core_lock)(&cpu);
@@ -6458,6 +6461,7 @@ static void sched_core_cpu_deactivate(unsigned int cpu)
if (t == cpu)
continue;
core_rq = cpu_rq(t);
+ core_id = t;
break;
}
@@ -6483,6 +6487,7 @@ static void sched_core_cpu_deactivate(unsigned int cpu)
for_each_cpu(t, smt_mask) {
rq = cpu_rq(t);
rq->core = core_rq;
+ rq->core_id = core_id;
}
}
@@ -6490,8 +6495,10 @@ static inline void sched_core_cpu_dying(unsigned int cpu)
{
struct rq *rq = cpu_rq(cpu);
- if (rq->core != rq)
+ if (rq->core != rq) {
rq->core = rq;
+ rq->core_id = cpu;
+ }
}
#else /* !CONFIG_SCHED_CORE */
@@ -10008,6 +10015,7 @@ void __init sched_init(void)
#ifdef CONFIG_SCHED_CORE
rq->core = rq;
+ rq->core_id = i;
rq->core_pick = NULL;
rq->core_enabled = 0;
rq->core_tree = RB_ROOT;
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 2e5a95486a42..1b62165fc840 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1121,6 +1121,7 @@ struct rq {
#ifdef CONFIG_SCHED_CORE
/* per rq */
struct rq *core;
+ unsigned int core_id;
struct task_struct *core_pick;
unsigned int core_enabled;
unsigned int core_sched_seq;
--
2.39.3
next prev parent reply other threads:[~2023-11-15 11:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 11:33 [PATCH 0/4] sched/core: fix cfs_prio_less Cruz Zhao
2023-11-15 11:33 ` Cruz Zhao [this message]
2023-11-15 11:33 ` [PATCH 2/4] sched/core: introduce core to struct cfs_rq Cruz Zhao
2023-11-15 20:08 ` kernel test robot
2023-11-15 20:19 ` kernel test robot
2023-11-18 10:48 ` kernel test robot
2023-11-15 11:33 ` [PATCH 3/4] sched/fair: introduce core_vruntime and core_min_vruntime Cruz Zhao
2023-11-15 12:20 ` Peter Zijlstra
2023-11-15 13:42 ` cruzzhao
2023-11-15 15:22 ` Peter Zijlstra
2023-11-16 6:38 ` cruzzhao
2023-11-17 2:48 ` cruzzhao
2023-11-15 20:51 ` kernel test robot
2023-11-15 11:33 ` [PATCH 4/4] sched/core: fix cfs_prio_less Cruz Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115113341.13261-2-CruzZhao@linux.alibaba.com \
--to=cruzzhao@linux.alibaba.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=joel@joelfernandes.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox