Re: [PATCH] media: dt-bindings: media: rkisp1: Fix the port description for the parallel interface

Laurent Pinchart
2023-11-16T00:51:45Z

Hi Mehdi,

Thank you for the patch.

On Wed, Nov 15, 2023 at 05:44:07PM +0100, Mehdi Djait wrote:
> The bus-type belongs to the endpoint's properties and should therefore
> be moved.
>
> Fixes: 6a0eaa25bf36 ("media: dt-bindings: media: rkisp1: Add port for parallel interface")
> Signed-off-by: Mehdi Djait <mehdi.djait@bootlin.com>

Good catch.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> .../devicetree/bindings/media/rockchip-isp1.yaml | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
> index e466dff8286d..afcaa427d48b 100644
> --- a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
> @@ -90,15 +90,16 @@ properties:
> description: connection point for input on the parallel interface
>
> properties:
> - bus-type:
> - enum: [5, 6]
> -
> endpoint:
> $ref: video-interfaces.yaml#
> unevaluatedProperties: false
>
> - required:
> - - bus-type
> + properties:
> + bus-type:
> + enum: [5, 6]
> +
> + required:
> + - bus-type
>
> anyOf:
> - required:

--
Regards,

Laurent Pinchart