Re: [PATCH [2/2]] dt-bindings: iio: humidity: Add TI HDC302x support

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2434 bytes --]

On Thu, Nov 16, 2023 at 09:14:07PM +0800, Li peiyu wrote:
> Add device tree bindings for HDC3020/HDC3021/HDC3022 humidity and
> temperature sensors.
> 
> Signed-off-by: Li peiyu <579lpy@gmail.com>
> ---
>  .../bindings/iio/humidity/ti,hdc3020.yaml     | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
> new file mode 100644
> index 000000000000..8015c4bb5b2f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/humidity/ti,hdc3020.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HDC3020/HDC3021/HDC3022 humidity and temperature iio sensors
> +
> +maintainers:
> +  - Jonathan Cameron <jic23@kernel.org>

Usually this is you, not the maintainer of the subsystem, since you have
the hardware in question and an interest in it specifically.

> +
> +description: |
> +  The HDC302x is an integrated capacitive based relative humidity (RH)
> +  and temperature sensor.
> +
> +  datasheet is available:
> +    https://www.ti.com/lit/ds/symlink/hdc3020.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,hdc3020
> +      - ti,hdc3021
> +      - ti,hdc3022

Looking at your driver, all three of these seem to be compatible?
I did only have a quick look though, so please correct me if that is not
the case. If they are compatible, please set this up to use a fallback
compatible - for example allow
compatible = "ti,hdc3020";
compatible = "ti,hdc3021", "ti,hdc3020";
compatible = "ti,hdc3022", "ti,hdc3020";

> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        humidity@47 {

The generic node name here should probably be "humidity-sensor".

Cheers,
Conor.

> +            compatible = "ti,hdc3020";
> +            reg = <0x47>;
> +        };
> +    };
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]