From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mehdi Djait <mehdi.djait@bootlin.com>
Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
conor+dt@kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com, alexandre.belloni@bootlin.com,
paul.kocialkowski@bootlin.com, dafna@fastmail.com,
helen.koike@collabora.com, heiko@sntech.de,
paul.elder@ideasonboard.com
Subject: Re: [PATCH] media: dt-bindings: media: rkisp1: Fix the port description for the parallel interface
Date: Thu, 16 Nov 2023 02:51:40 +0200 [thread overview]
Message-ID: <20231116005140.GB21041@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20231115164407.99876-1-mehdi.djait@bootlin.com>
Hi Mehdi,
Thank you for the patch.
On Wed, Nov 15, 2023 at 05:44:07PM +0100, Mehdi Djait wrote:
> The bus-type belongs to the endpoint's properties and should therefore
> be moved.
>
> Fixes: 6a0eaa25bf36 ("media: dt-bindings: media: rkisp1: Add port for parallel interface")
> Signed-off-by: Mehdi Djait <mehdi.djait@bootlin.com>
Good catch.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../devicetree/bindings/media/rockchip-isp1.yaml | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
> index e466dff8286d..afcaa427d48b 100644
> --- a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
> @@ -90,15 +90,16 @@ properties:
> description: connection point for input on the parallel interface
>
> properties:
> - bus-type:
> - enum: [5, 6]
> -
> endpoint:
> $ref: video-interfaces.yaml#
> unevaluatedProperties: false
>
> - required:
> - - bus-type
> + properties:
> + bus-type:
> + enum: [5, 6]
> +
> + required:
> + - bus-type
>
> anyOf:
> - required:
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2023-11-16 0:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 16:44 [PATCH] media: dt-bindings: media: rkisp1: Fix the port description for the parallel interface Mehdi Djait
2023-11-16 0:51 ` Laurent Pinchart [this message]
2023-11-16 14:37 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231116005140.GB21041@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=dafna@fastmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mehdi.djait@bootlin.com \
--cc=paul.elder@ideasonboard.com \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox