From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
mingo@redhat.com, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, viresh.kumar@linaro.org,
qyousef@layalina.io, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, lukasz.luba@arm.com,
wyes.karny@amd.com, beata.michalska@arm.com
Subject: Re: [PATCH v3 0/2] Rework interface between scheduler and schedutil governor
Date: Thu, 16 Nov 2023 15:34:50 +0100 [thread overview]
Message-ID: <20231116143450.GF8262@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJZ5v0g4N2UojiQqJn7fxWj2=h=6sgFfGEqEVx1wuh2VdvaH6Q@mail.gmail.com>
On Mon, Nov 06, 2023 at 04:05:40PM +0100, Rafael J. Wysocki wrote:
> On Fri, Nov 3, 2023 at 2:18 PM Vincent Guittot
> <vincent.guittot@linaro.org> wrote:
> >
> > Following the discussion with Qais [1] about how to handle uclamp
> > requirements and after syncing with him, we agreed that I should move
> > forward on the patchset to rework the interface between scheduler and
> > schedutil governor to provide more information to the latter. Scheduler
> > (and EAS in particular) doesn't need anymore to guess estimate which
> > headroom the governor wants to apply and will directly ask for the target
> > freq. Then the governor directly gets the actual utilization and new
> > minimum and maximum boundaries to select this target frequency and
> > doesn't have to deal anymore with scheduler internals like uclamp when
> > including iowait boost.
> >
> > [1] https://lore.kernel.org/lkml/CAKfTPtA5JqNCauG-rP3wGfq+p8EEVx9Tvwj6ksM3SYCwRmfCTg@mail.gmail.com/
> >
> > Changes since v2:
> > - remove useless target variable
> >
> > Changes since v1:
> > - fix a bug (always set max even when returning early)
> > - fix typos
> >
> > Vincent Guittot (2):
> > sched/schedutil: Rework performance estimation
> > sched/schedutil: Rework iowait boost
> >
> > include/linux/energy_model.h | 1 -
> > kernel/sched/core.c | 82 ++++++++++++-------------------
> > kernel/sched/cpufreq_schedutil.c | 69 ++++++++++++++++----------
> > kernel/sched/fair.c | 22 +++++++--
> > kernel/sched/sched.h | 84 +++-----------------------------
> > 5 files changed, 100 insertions(+), 158 deletions(-)
> >
> > --
>
> For the schedutil changes in the series:
>
> Acked-by: Rafael J. Wysocki <rafael@kernel.org>
>
> and I'm assuming this series to be targeted at sched.
Sure, I'll go queue it. Thanks!
next prev parent reply other threads:[~2023-11-16 14:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 13:18 [PATCH v3 0/2] Rework interface between scheduler and schedutil governor Vincent Guittot
2023-11-03 13:18 ` [PATCH v3 1/2] sched/schedutil: Rework performance estimation Vincent Guittot
2023-11-14 20:54 ` Qais Yousef
2023-11-22 7:38 ` Vincent Guittot
2023-11-21 21:17 ` Qais Yousef
2023-11-23 7:47 ` Vincent Guittot
2023-11-21 22:09 ` Qais Yousef
2023-11-23 13:32 ` Vincent Guittot
2023-11-21 22:31 ` Qais Yousef
2023-11-16 13:19 ` Lukasz Luba
2023-11-03 13:18 ` [PATCH v3 2/2] sched/schedutil: Rework iowait boost Vincent Guittot
2023-11-14 20:59 ` Qais Yousef
2023-11-06 15:05 ` [PATCH v3 0/2] Rework interface between scheduler and schedutil governor Rafael J. Wysocki
2023-11-16 14:34 ` Peter Zijlstra [this message]
2023-11-14 21:13 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231116143450.GF8262@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=beata.michalska@arm.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=qyousef@layalina.io \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vschneid@redhat.com \
--cc=wyes.karny@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox