From: Peter Zijlstra <peterz@infradead.org>
To: kan.liang@linux.intel.com
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
artem.bityutskiy@linux.intel.com, rui.zhang@intel.com
Subject: Re: [RESEND PATCH 2/4] x86/smp: Export symbol cpu_clustergroup_mask
Date: Thu, 16 Nov 2023 15:40:34 +0100 [thread overview]
Message-ID: <20231116144034.GG8262@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20231116142245.1233485-2-kan.liang@linux.intel.com>
On Thu, Nov 16, 2023 at 06:22:43AM -0800, kan.liang@linux.intel.com wrote:
> From: Kan Liang <kan.liang@linux.intel.com>
>
> Intel cstate PMU driver will invoke the topology_cluster_cpumask() to
> retrieve the CPU mask of a cluster. A modpost error is triggered since
> the symbol cpu_clustergroup_mask is not exported.
>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> ---
> arch/x86/kernel/smpboot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index 48e040618731..376387ca6be5 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -747,6 +747,7 @@ const struct cpumask *cpu_clustergroup_mask(int cpu)
> {
> return cpu_l2c_shared_mask(cpu);
> }
> +EXPORT_SYMBOL(cpu_clustergroup_mask);
I made that _GPL.
Queued the lot.
next prev parent reply other threads:[~2023-11-16 14:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 14:22 [RESEND PATCH 1/4] perf/x86/intel/cstate: Cleanup duplicate attr_groups kan.liang
2023-11-16 14:22 ` [RESEND PATCH 2/4] x86/smp: Export symbol cpu_clustergroup_mask kan.liang
2023-11-16 14:40 ` Peter Zijlstra [this message]
2023-11-16 15:20 ` Liang, Kan
2023-11-20 14:35 ` [tip: perf/core] x86/smp: Export symbol cpu_clustergroup_mask() tip-bot2 for Kan Liang
2023-11-16 14:22 ` [RESEND PATCH 3/4] perf/x86/intel/cstate: Add Sierra Forest support kan.liang
2023-11-20 14:35 ` [tip: perf/core] " tip-bot2 for Kan Liang
2023-11-16 14:22 ` [RESEND PATCH 4/4] perf/x86/intel/cstate: Add Grand Ridge support kan.liang
2023-11-20 14:35 ` [tip: perf/core] " tip-bot2 for Kan Liang
2023-11-20 14:35 ` [tip: perf/core] perf/x86/intel/cstate: Cleanup duplicate attr_groups tip-bot2 for Kan Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231116144034.GG8262@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=artem.bityutskiy@linux.intel.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox