From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Yuanyuan Zhong <yzhong@purestorage.com>,
Jens Axboe <axboe@kernel.dk>,
hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org, randyj@purestorage.com,
hcoutinho@purestorage.com
Subject: Re: [PATCH] nvme-core: remove head->effects to fix use-after-free
Date: Fri, 17 Nov 2023 14:28:46 +0100 [thread overview]
Message-ID: <20231117132846.GB7867@lst.de> (raw)
In-Reply-To: <ZVWR4Rtr1N7IF6iQ@kbusch-mbp.dhcp.thefacebook.com>
On Wed, Nov 15, 2023 at 10:52:01PM -0500, Keith Busch wrote:
>
> Yes, in section 5.16.1.6, "Commands Supported and Effects":
>
> This log page is used to describe the commands that the controller
> supports and the effects of those commands on the state of the NVM
> subsystem.
>
> Oddly enough, Figure 202 says the scope of the log page is "Controller"
> rather than "Subsystem". Sounds like ECN potential. You can memcmp the
> effects log from each controller for a sanity check if you think some
> subsystem controllers messed that up.
If we really want to be 111% sure we could read the effects for all
controllers and do a logical OR of them, but I think the reason for the
per-controller scope is that for odd subsystems where different
controllers don't actually access the same namespaces these flags
could be different, i.e. one that only does KV, one that does ZNS,
one that does NVM and one that is just an administrative controller.
next prev parent reply other threads:[~2023-11-17 13:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 18:54 [PATCH] nvme-core: remove head->effects to fix use-after-free Yuanyuan Zhong
2023-11-15 19:02 ` Jens Axboe
2023-11-15 19:21 ` Yuanyuan Zhong
2023-11-15 19:55 ` Keith Busch
2023-11-15 22:44 ` Yuanyuan Zhong
2023-11-16 3:52 ` Keith Busch
2023-11-16 19:12 ` Yuanyuan Zhong
2023-11-17 13:28 ` Christoph Hellwig [this message]
2023-11-17 16:38 ` Keith Busch
2023-11-20 8:23 ` Christoph Hellwig
2023-11-20 10:18 ` Sagi Grimberg
2023-11-20 23:31 ` Randy Jennings
2023-11-15 23:42 ` kernel test robot
2023-11-19 19:29 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231117132846.GB7867@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hcoutinho@purestorage.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=randyj@purestorage.com \
--cc=sagi@grimberg.me \
--cc=yzhong@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox