From: Bjorn Helgaas <helgaas@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Kalle Valo <kvalo@kernel.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] wifi: rtlwifi: Convert to use PCIe capability accessors
Date: Fri, 17 Nov 2023 16:37:38 -0600 [thread overview]
Message-ID: <20231117223738.GA95634@bhelgaas> (raw)
In-Reply-To: <20231117094425.80477-3-ilpo.jarvinen@linux.intel.com>
On Fri, Nov 17, 2023 at 11:44:20AM +0200, Ilpo Järvinen wrote:
> The rtlwifi driver accesses PCIe capabilities through custom config
> offsets.
>
> Convert the accesses to use the normal PCIe capability accessors.
> pcibridge_pciehdr_offset in the struct mp_adapter becomes unused after
> the conversion and can be removed.
More good stuff. I guess patch [1/7] was specifically for the RMW
things, and this one is for the rest?
> @@ -219,7 +220,7 @@ static void rtl_pci_disable_aspm(struct ieee80211_hw *hw)
> }
>
> /*for promising device will in L0 state after an I/O. */
> - pci_read_config_byte(rtlpci->pdev, 0x80, &tmp_u1b);
> + pcie_capability_read_word(rtlpci->pdev, PCI_EXP_LNKCTL, &tmp_u1b);
>
> /*Set corresponding value. */
> aspmlevel |= BIT(0) | BIT(1);
I guess this is PCI_EXP_LNKCTL_ASPM_L0S | PCI_EXP_LNKCTL_ASPM_L1?
There's also a similar u_pcibridge_aspmsetting mask in
rtl_pci_enable_aspm().
And some scary looking stuff in rtl_pci_get_amd_l1_patch(). And
platform_enable_dma64(). No clue what either of those does.
next prev parent reply other threads:[~2023-11-17 22:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 9:44 [PATCH 0/7] rtlwifi: PCIe capability access fix + improvements Ilpo Järvinen
2023-11-17 9:44 ` [PATCH 1/7] wifi: rtlwifi: Convert LNKCTL change to PCIe cap RMW accessors Ilpo Järvinen
2023-11-17 22:24 ` Bjorn Helgaas
2023-11-20 9:25 ` Ilpo Järvinen
2023-11-22 14:54 ` Kalle Valo
2023-11-17 9:44 ` [PATCH 2/7] wifi: rtlwifi: Convert to use PCIe capability accessors Ilpo Järvinen
2023-11-17 22:37 ` Bjorn Helgaas [this message]
2023-11-20 8:54 ` Ilpo Järvinen
2023-11-17 9:44 ` [PATCH 3/7] rtlwifi: rtl8821ae: Remove unnecessary PME_Status bit set Ilpo Järvinen
2023-11-17 9:44 ` [PATCH 4/7] rtlwifi: rtl8821ae: Reverse PM capability exists check Ilpo Järvinen
2023-11-17 22:44 ` Bjorn Helgaas
2023-11-20 9:59 ` Ilpo Järvinen
2023-11-17 9:44 ` [PATCH 5/7] rtlwifi: rtl8821ae: Use pci_find_capability() Ilpo Järvinen
2023-11-17 22:46 ` Bjorn Helgaas
2023-11-17 9:44 ` [PATCH 6/7] rtlwifi: rtl8821ae: Add pdev into _rtl8821ae_clear_pci_pme_status() Ilpo Järvinen
2023-11-17 9:44 ` [PATCH 7/7] rtlwifi: rtl8821ae: Access full PMCS reg and use pci_regs.h Ilpo Järvinen
2023-11-17 22:48 ` Bjorn Helgaas
2023-11-20 10:06 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231117223738.GA95634@bhelgaas \
--to=helgaas@kernel.org \
--cc=Larry.Finger@lwfinger.net \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox