From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2ADEC072A2 for ; Fri, 17 Nov 2023 19:48:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231868AbjKQTsj (ORCPT ); Fri, 17 Nov 2023 14:48:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230186AbjKQTsi (ORCPT ); Fri, 17 Nov 2023 14:48:38 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A751D5C for ; Fri, 17 Nov 2023 11:48:35 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5718C433C8; Fri, 17 Nov 2023 19:48:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700250515; bh=X7JZz+ON7qSHlA37jt4TpJnFpH56zWbengdGSXs0b9Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZY+8uqWgJilAslNYbhHRu3b8/mWuvqc21zHQ1flxkaFfL2/4HqnaRvX8m/Bonwhgz PoJkrKPLwpS3MQ8InlyKUNZ/IxISURrNYJTLuUEeaf7/Vxza3vSl/LKcD4kY9cdZTb KhVohOBGaaijinUxkd8GOHHrSn2FrVB/uLTyRJb4= Date: Fri, 17 Nov 2023 14:48:32 -0500 From: Greg Kroah-Hartman To: Andrew Lunn Cc: Kory Maincent , Luis Chamberlain , Russ Weight , "Rafael J. Wysocki" , Thomas Petazzoni , linux-kernel@vger.kernel.org, Conor Dooley Subject: Re: [PATCH] firmware_loader: Expand Firmware upload error codes with firmware invalid error Message-ID: <2023111727-exert-dab-b940@gregkh> References: <20231117-feature_firmware_error_code-v1-1-92c973a50847@bootlin.com> <2023111720-slicer-exes-7d9f@gregkh> <548c3b60-60ce-4166-9943-224e03152cc5@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <548c3b60-60ce-4166-9943-224e03152cc5@lunn.ch> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 17, 2023 at 03:06:44PM +0100, Andrew Lunn wrote: > On Fri, Nov 17, 2023 at 08:45:59AM -0500, Greg Kroah-Hartman wrote: > > On Fri, Nov 17, 2023 at 11:27:53AM +0100, Kory Maincent wrote: > > > No error code are available to signal an invalid firmware content. > > > Drivers that can check the firmware content validity can not return this > > > specific failure to the user-space > > > > > > Expand the firmware error code with an additional code: > > > - "firmware invalid" code which can be used when the provided firmware > > > is invalid > > > > > > Acked-by: Luis Chamberlain > > > Acked-by: Greg Kroah-Hartman > > > Signed-off-by: Kory Maincent > > > --- > > > > > > This patch was initially submitted as part of a net patch series. > > > Conor expressed interest in using it in a different subsystem. > > > Consequently, I extracted it from the series and submitted it separately > > > to the main tree, driver-core. > > > https://lore.kernel.org/netdev/20231116-feature_poe-v1-7-be48044bf249@bootlin.com/ > > > > So you want me to take it through my tree? Sure, but if you are relying > > on this for any other code, it will be a while before it gets into > > Linus's tree, not until 6.8-rc1, is that ok? > > My idea was that you could create a stable branch, which can then be > pulled into netdev and arm-soc. I'll be glad to do so, you just need to ask me to do that, I don't see that request here :) > If you don't want to do that, we can ask Arnd to take it, and he can > create a stable branch which we pull into netdev. You want a stable tag to pull from, right? But really, why not just take this through netdev? It's just one commit, I have no problem with it going that way at all. If the odd chance there's a merge conflict in the future, I can handle it. thanks, greg k-h