From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wolfram Sang <wsa@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Alex Deucher <alexander.deucher@amd.com>
Subject: [PATCH v3 19/20] drivers/gpu/drm/display: remove I2C_CLASS_DDC support
Date: Sun, 19 Nov 2023 11:14:44 +0100 [thread overview]
Message-ID: <20231119101445.4737-20-hkallweit1@gmail.com> (raw)
In-Reply-To: <20231119101445.4737-1-hkallweit1@gmail.com>
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/display/drm_dp_helper.c | 1 -
drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
index f3680f4e6..ac901f4b4 100644
--- a/drivers/gpu/drm/display/drm_dp_helper.c
+++ b/drivers/gpu/drm/display/drm_dp_helper.c
@@ -2102,7 +2102,6 @@ int drm_dp_aux_register(struct drm_dp_aux *aux)
if (!aux->ddc.algo)
drm_dp_aux_init(aux);
- aux->ddc.class = I2C_CLASS_DDC;
aux->ddc.owner = THIS_MODULE;
aux->ddc.dev.parent = aux->dev;
diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
index 0e0d0e76d..4376e2c1f 100644
--- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
@@ -5803,7 +5803,6 @@ static int drm_dp_mst_register_i2c_bus(struct drm_dp_mst_port *port)
aux->ddc.algo_data = aux;
aux->ddc.retries = 3;
- aux->ddc.class = I2C_CLASS_DDC;
aux->ddc.owner = THIS_MODULE;
/* FIXME: set the kdev of the port's connector as parent */
aux->ddc.dev.parent = parent_dev;
next prev parent reply other threads:[~2023-11-19 10:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-19 10:14 [PATCH 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: " Heiner Kallweit
2023-11-20 11:34 ` Thomas Zimmermann
2023-11-19 10:14 ` [PATCH v3 03/20] drm/amd/display: " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 05/20] drivers/video/fbdev: " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 06/20] drivers/video/fbdev/core/fb_ddc.c: " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 07/20] drivers/gpu/drm: " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 09/20] drivers/video/fbdev/via/via_i2c.c: " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: " Heiner Kallweit
2024-01-22 15:31 ` Robert Foss
2023-11-19 10:14 ` [PATCH v3 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 15/20] drivers/gpu/drm/i915/display: " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: " Heiner Kallweit
2023-11-19 10:14 ` [PATCH v3 17/20] drivers/gpu/drm/ast/ast_i2c.c: " Heiner Kallweit
2023-11-20 11:35 ` Thomas Zimmermann
2023-11-19 10:14 ` [PATCH v3 18/20] drivers/gpu/drm/gma500: " Heiner Kallweit
2023-11-19 10:14 ` Heiner Kallweit [this message]
2023-11-19 10:14 ` [PATCH v3 20/20] include/linux/i2c.h: " Heiner Kallweit
-- strict thread matches above, loose matches on Subject: below --
2023-11-19 11:28 [PATCH v3 RESEND 00/20] " Heiner Kallweit
2023-11-19 11:28 ` [PATCH v3 19/20] drivers/gpu/drm/display: " Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231119101445.4737-20-hkallweit1@gmail.com \
--to=hkallweit1@gmail.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox