From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DE7DC197A0 for ; Mon, 20 Nov 2023 10:02:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232800AbjKTKC0 (ORCPT ); Mon, 20 Nov 2023 05:02:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232495AbjKTKCV (ORCPT ); Mon, 20 Nov 2023 05:02:21 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7655B95 for ; Mon, 20 Nov 2023 02:02:17 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FE3EC433CA; Mon, 20 Nov 2023 10:02:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700474537; bh=lytuxTkPB0okNqk+8s8bs37ZXG5dyB+2G+cEs+pRKrQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KxELYPkozyB8TtUxqn6hWTyg2QO+i8CSsK/BaMsBOQDfYQrwrWJ6718zFPrgXDgIc ROV5K/YchAwP/1GJuBAG0NitqStT46SWnBfngO3S8XtW6CZIBASY29YBlq7PnmOyzu 57s28oILGyKGqrMRa01blz9s+oNFjzjofJU1oE4k= Date: Mon, 20 Nov 2023 11:02:13 +0100 From: Greg KH To: Su Hui Cc: tomas.winkler@intel.com, arnd@arndb.de, alexander.usyskin@intel.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2 1/2] misc: mei: client.c: return negative error code in mei_cl_write Message-ID: <2023112003-earflap-mule-5b03@gregkh> References: <20231120095523.178385-1-suhui@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231120095523.178385-1-suhui@nfschina.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2023 at 05:55:23PM +0800, Su Hui wrote: > mei_msg_hdr_init() return negative error code, rets should be > 'PTR_ERR(mei_hdr)' rather than '-PTR_ERR(mei_hdr)'. > > Fixes: 0cd7c01a60f8 ("mei: add support for mei extended header.") > Signed-off-by: Su Hui > --- > v2: split v1 patch to different patches > v1: https://lore.kernel.org/all/5c98fc07-36a9-92cc-f8d6-c4efdc0c34aa@nfschina.com/ > > drivers/misc/mei/client.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c > index 9c8fc87938a7..7ea80779a0e2 100644 > --- a/drivers/misc/mei/client.c > +++ b/drivers/misc/mei/client.c > @@ -2011,7 +2011,7 @@ ssize_t mei_cl_write(struct mei_cl *cl, struct mei_cl_cb *cb, unsigned long time > > mei_hdr = mei_msg_hdr_init(cb); > if (IS_ERR(mei_hdr)) { > - rets = -PTR_ERR(mei_hdr); > + rets = PTR_ERR(mei_hdr); > mei_hdr = NULL; > goto err; > } > -- > 2.30.2 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot