public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* drivers/hwtracing/intel_th/core.c:795: warning: Function parameter or member 'drvdata' not described in 'intel_th_alloc'
@ 2023-11-19 21:34 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-11-19 21:34 UTC (permalink / raw)
  To: Alexander Shishkin; +Cc: oe-kbuild-all, linux-kernel

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   037266a5f7239ead1530266f7d7af153d2a867fa
commit: 3321371b5d648479058fa6f9441168abbc1467c9 intel_th: pci: Use drvdata for quirks
date:   6 years ago
config: x86_64-buildonly-randconfig-001-20231012 (https://download.01.org/0day-ci/archive/20231120/202311200521.j8ybmtiW-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231120/202311200521.j8ybmtiW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311200521.j8ybmtiW-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/hwtracing/intel_th/core.c:795: warning: Function parameter or member 'drvdata' not described in 'intel_th_alloc'


vim +795 drivers/hwtracing/intel_th/core.c

39f4034693b7c7 Alexander Shishkin 2015-09-22  784  
39f4034693b7c7 Alexander Shishkin 2015-09-22  785  /**
39f4034693b7c7 Alexander Shishkin 2015-09-22  786   * intel_th_alloc() - allocate a new Intel TH device and its subdevices
39f4034693b7c7 Alexander Shishkin 2015-09-22  787   * @dev:	parent device
39f4034693b7c7 Alexander Shishkin 2015-09-22  788   * @devres:	parent's resources
39f4034693b7c7 Alexander Shishkin 2015-09-22  789   * @ndevres:	number of resources
39f4034693b7c7 Alexander Shishkin 2015-09-22  790   * @irq:	irq number
39f4034693b7c7 Alexander Shishkin 2015-09-22  791   */
39f4034693b7c7 Alexander Shishkin 2015-09-22  792  struct intel_th *
3321371b5d6484 Alexander Shishkin 2017-08-18  793  intel_th_alloc(struct device *dev, struct intel_th_drvdata *drvdata,
3321371b5d6484 Alexander Shishkin 2017-08-18  794  	       struct resource *devres, unsigned int ndevres, int irq)
39f4034693b7c7 Alexander Shishkin 2015-09-22 @795  {
39f4034693b7c7 Alexander Shishkin 2015-09-22  796  	struct intel_th *th;
39f4034693b7c7 Alexander Shishkin 2015-09-22  797  	int err;
39f4034693b7c7 Alexander Shishkin 2015-09-22  798  
39f4034693b7c7 Alexander Shishkin 2015-09-22  799  	th = kzalloc(sizeof(*th), GFP_KERNEL);
39f4034693b7c7 Alexander Shishkin 2015-09-22  800  	if (!th)
39f4034693b7c7 Alexander Shishkin 2015-09-22  801  		return ERR_PTR(-ENOMEM);
39f4034693b7c7 Alexander Shishkin 2015-09-22  802  
39f4034693b7c7 Alexander Shishkin 2015-09-22  803  	th->id = ida_simple_get(&intel_th_ida, 0, 0, GFP_KERNEL);
39f4034693b7c7 Alexander Shishkin 2015-09-22  804  	if (th->id < 0) {
39f4034693b7c7 Alexander Shishkin 2015-09-22  805  		err = th->id;
39f4034693b7c7 Alexander Shishkin 2015-09-22  806  		goto err_alloc;
39f4034693b7c7 Alexander Shishkin 2015-09-22  807  	}
39f4034693b7c7 Alexander Shishkin 2015-09-22  808  
39f4034693b7c7 Alexander Shishkin 2015-09-22  809  	th->major = __register_chrdev(0, 0, TH_POSSIBLE_OUTPUTS,
39f4034693b7c7 Alexander Shishkin 2015-09-22  810  				      "intel_th/output", &intel_th_output_fops);
39f4034693b7c7 Alexander Shishkin 2015-09-22  811  	if (th->major < 0) {
39f4034693b7c7 Alexander Shishkin 2015-09-22  812  		err = th->major;
39f4034693b7c7 Alexander Shishkin 2015-09-22  813  		goto err_ida;
39f4034693b7c7 Alexander Shishkin 2015-09-22  814  	}
39f4034693b7c7 Alexander Shishkin 2015-09-22  815  	th->dev = dev;
3321371b5d6484 Alexander Shishkin 2017-08-18  816  	th->drvdata = drvdata;
39f4034693b7c7 Alexander Shishkin 2015-09-22  817  
a753bfcfdb1f31 Alexander Shishkin 2017-08-10  818  	th->resource = devres;
a753bfcfdb1f31 Alexander Shishkin 2017-08-10  819  	th->num_resources = ndevres;
a753bfcfdb1f31 Alexander Shishkin 2017-08-10  820  	th->irq = irq;
a753bfcfdb1f31 Alexander Shishkin 2017-08-10  821  
d7b1787161b78a Alexander Shishkin 2016-02-15  822  	dev_set_drvdata(dev, th);
d7b1787161b78a Alexander Shishkin 2016-02-15  823  
142dfeb2020960 Alexander Shishkin 2016-06-22  824  	pm_runtime_no_callbacks(dev);
142dfeb2020960 Alexander Shishkin 2016-06-22  825  	pm_runtime_put(dev);
142dfeb2020960 Alexander Shishkin 2016-06-22  826  	pm_runtime_allow(dev);
142dfeb2020960 Alexander Shishkin 2016-06-22  827  
a753bfcfdb1f31 Alexander Shishkin 2017-08-10  828  	err = intel_th_populate(th);
a753bfcfdb1f31 Alexander Shishkin 2017-08-10  829  	if (err) {
a753bfcfdb1f31 Alexander Shishkin 2017-08-10  830  		/* free the subdevices and undo everything */
a753bfcfdb1f31 Alexander Shishkin 2017-08-10  831  		intel_th_free(th);
a753bfcfdb1f31 Alexander Shishkin 2017-08-10  832  		return ERR_PTR(err);
a753bfcfdb1f31 Alexander Shishkin 2017-08-10  833  	}
39f4034693b7c7 Alexander Shishkin 2015-09-22  834  
39f4034693b7c7 Alexander Shishkin 2015-09-22  835  	return th;
39f4034693b7c7 Alexander Shishkin 2015-09-22  836  
39f4034693b7c7 Alexander Shishkin 2015-09-22  837  err_ida:
39f4034693b7c7 Alexander Shishkin 2015-09-22  838  	ida_simple_remove(&intel_th_ida, th->id);
39f4034693b7c7 Alexander Shishkin 2015-09-22  839  
39f4034693b7c7 Alexander Shishkin 2015-09-22  840  err_alloc:
39f4034693b7c7 Alexander Shishkin 2015-09-22  841  	kfree(th);
39f4034693b7c7 Alexander Shishkin 2015-09-22  842  
39f4034693b7c7 Alexander Shishkin 2015-09-22  843  	return ERR_PTR(err);
39f4034693b7c7 Alexander Shishkin 2015-09-22  844  }
39f4034693b7c7 Alexander Shishkin 2015-09-22  845  EXPORT_SYMBOL_GPL(intel_th_alloc);
39f4034693b7c7 Alexander Shishkin 2015-09-22  846  

:::::: The code at line 795 was first introduced by commit
:::::: 39f4034693b7c7bd1fe4cb58c93259d600f55561 intel_th: Add driver infrastructure for Intel(R) Trace Hub devices

:::::: TO: Alexander Shishkin <alexander.shishkin@linux.intel.com>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-11-19 21:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-19 21:34 drivers/hwtracing/intel_th/core.c:795: warning: Function parameter or member 'drvdata' not described in 'intel_th_alloc' kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox