From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Yuanyuan Zhong <yzhong@purestorage.com>,
Jens Axboe <axboe@kernel.dk>,
sagi@grimberg.me, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org, randyj@purestorage.com,
hcoutinho@purestorage.com
Subject: Re: [PATCH] nvme-core: remove head->effects to fix use-after-free
Date: Mon, 20 Nov 2023 09:23:46 +0100 [thread overview]
Message-ID: <20231120082346.GA11622@lst.de> (raw)
In-Reply-To: <ZVeW-8cNNVOvNdaR@kbusch-mbp.dhcp.thefacebook.com>
On Fri, Nov 17, 2023 at 09:38:19AM -0700, Keith Busch wrote:
> The effects log is per-CSI so different command sets won't create
> conflicts.
True. But that wasn't the point anyway. It is that different
controllers might expose very different namespaes with different
capabilities. Maybe a controller with HDD namespaces vs flash might
be a better example.
> Namespaces that are not shared don't really matter here because this
> problem is unique to mulitpath.
Indeed.
> It doesn't make sense for effects logs to be different per-controller
> for the same shared namespace. The spec doesn't seem to explicitly
> prevent that, but hints that all hosts should be seeing the same thing
> no matter which controller they're connected to:
Also agreed as already indicated in the past mail.
next prev parent reply other threads:[~2023-11-20 8:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 18:54 [PATCH] nvme-core: remove head->effects to fix use-after-free Yuanyuan Zhong
2023-11-15 19:02 ` Jens Axboe
2023-11-15 19:21 ` Yuanyuan Zhong
2023-11-15 19:55 ` Keith Busch
2023-11-15 22:44 ` Yuanyuan Zhong
2023-11-16 3:52 ` Keith Busch
2023-11-16 19:12 ` Yuanyuan Zhong
2023-11-17 13:28 ` Christoph Hellwig
2023-11-17 16:38 ` Keith Busch
2023-11-20 8:23 ` Christoph Hellwig [this message]
2023-11-20 10:18 ` Sagi Grimberg
2023-11-20 23:31 ` Randy Jennings
2023-11-15 23:42 ` kernel test robot
2023-11-19 19:29 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231120082346.GA11622@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hcoutinho@purestorage.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=randyj@purestorage.com \
--cc=sagi@grimberg.me \
--cc=yzhong@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox