From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17171C2BB3F for ; Mon, 20 Nov 2023 16:48:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232330AbjKTQsN (ORCPT ); Mon, 20 Nov 2023 11:48:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230451AbjKTQsL (ORCPT ); Mon, 20 Nov 2023 11:48:11 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47F2393 for ; Mon, 20 Nov 2023 08:48:08 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91183C433C7; Mon, 20 Nov 2023 16:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700498887; bh=ESh01jqSQWkTBYBeIvcosjdQy4FIhEmQsKnmw7vBqNw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fkyLtgYDEV2bf5laQJi0/RvJtLahfgLpzfonczwYtiUCKRzmqrG/k39dKN1XoF6sg Jc0PXqlhyKurmcq24L6vyVeoLsN9huxzhMQl+Zc1YeG7RbMhMzDTlt5NPof2kqVxHj keod2SkcB2wGqjre3HrbIJUkjBgoLc01pgh+dpEFg+V+AGK0ITO58tGLii9rPJvqAv eAEVJpvP668lMwaZiDRczWoa8tm+9fa1SsAsJVRQXoVD+8xnlNybSvj/83fc4Q7hCg PvGKf+gpB21QW70HQ1M0G5u3N9QokEAA15KNz/peCyxmn79Sh18Er6LMXJqWyE7h5A ID03DQ4dHFF0Q== Date: Mon, 20 Nov 2023 08:48:05 -0800 From: Jakub Kicinski To: =?UTF-8?B?S8O2cnk=?= Maincent Cc: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Radu Pirea , Jay Vosburgh , Andy Gospodarek , Nicolas Ferre , Claudiu Beznea , Willem de Bruijn , Jonathan Corbet , Horatiu Vultur , UNGLinuxDriver@microchip.com, Simon Horman , Vladimir Oltean , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Maxime Chevallier Subject: Re: [PATCH net-next v7 07/16] net_tstamp: Add TIMESTAMPING SOFTWARE and HARDWARE mask Message-ID: <20231120084805.5f012a40@kernel.org> In-Reply-To: <20231120100549.22c83bd0@kmaincent-XPS-13-7390> References: <20231114-feature_ptp_netnext-v7-0-472e77951e40@bootlin.com> <20231114-feature_ptp_netnext-v7-7-472e77951e40@bootlin.com> <20231118182247.638c0feb@kernel.org> <20231120100549.22c83bd0@kmaincent-XPS-13-7390> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Nov 2023 10:05:49 +0100 K=C3=B6ry Maincent wrote: > > Does this really need to be in uAPI? =20 >=20 > I have put it in the same place as SOF_TIMESTAMPING_* flags but indeed I = am not > sure ethtool would need it. > I can move it to include/linux/net_tstamp.h and we will move back to uapi= if > we see that it is necessary. What do you think? include/linux/net_tstamp.h sounds better to me, Willem may disagree..