public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Wolfram Sang <wsa@kernel.org>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>
Subject: [PATCH v4 11/24] i2c: designware: Drop return value from i2c_dw_acpi_configure()
Date: Mon, 20 Nov 2023 16:41:53 +0200	[thread overview]
Message-ID: <20231120144641.1660574-12-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20231120144641.1660574-1-andriy.shevchenko@linux.intel.com>

i2c_dw_acpi_configure() is called without checking of the returned
value, hence just drop it by converting to void.

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/i2c/busses/i2c-designware-common.c | 4 +---
 drivers/i2c/busses/i2c-designware-core.h   | 4 ++--
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c
index 35f762872b8a..7a53a732981b 100644
--- a/drivers/i2c/busses/i2c-designware-common.c
+++ b/drivers/i2c/busses/i2c-designware-common.c
@@ -255,7 +255,7 @@ static void i2c_dw_acpi_params(struct device *device, char method[],
 	kfree(buf.pointer);
 }
 
-int i2c_dw_acpi_configure(struct device *device)
+void i2c_dw_acpi_configure(struct device *device)
 {
 	struct dw_i2c_dev *dev = dev_get_drvdata(device);
 	struct i2c_timings *t = &dev->timings;
@@ -285,8 +285,6 @@ int i2c_dw_acpi_configure(struct device *device)
 		dev->sda_hold_time = fs_ht;
 		break;
 	}
-
-	return 0;
 }
 EXPORT_SYMBOL_GPL(i2c_dw_acpi_configure);
 
diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h
index f8dd87cb0ae9..b7884f15e0e9 100644
--- a/drivers/i2c/busses/i2c-designware-core.h
+++ b/drivers/i2c/busses/i2c-designware-core.h
@@ -399,7 +399,7 @@ int i2c_dw_validate_speed(struct dw_i2c_dev *dev);
 void i2c_dw_adjust_bus_speed(struct dw_i2c_dev *dev);
 
 #if IS_ENABLED(CONFIG_ACPI)
-int i2c_dw_acpi_configure(struct device *device);
+void i2c_dw_acpi_configure(struct device *device);
 #else
-static inline int i2c_dw_acpi_configure(struct device *device) { return -ENODEV; }
+static inline void i2c_dw_acpi_configure(struct device *device) { }
 #endif
-- 
2.43.0.rc1.1.gbec44491f096


  parent reply	other threads:[~2023-11-20 14:47 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-20 14:41 [PATCH v4 00/24] i2c: designware: code consolidation & cleanups Andy Shevchenko
2023-11-20 14:41 ` [PATCH v4 01/24] i2c: designware: Fix PM calls order in dw_i2c_plat_probe() Andy Shevchenko
2023-11-26 21:48   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 02/24] i2c: designware: Fix reset call " Andy Shevchenko
2023-11-26 21:57   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 03/24] i2c: designware: Let PCI core to take care about interrupt vectors Andy Shevchenko
2023-11-26 22:03   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 04/24] i2c: designware: Fix lock probe call order in dw_i2c_plat_probe() Andy Shevchenko
2023-11-26 22:23   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 05/24] i2c: designware: Replace a while-loop by for-loop Andy Shevchenko
2023-11-26 22:27   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 06/24] i2c: designware: Save pointer to semaphore callbacks instead of index Andy Shevchenko
2023-11-26 22:38   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 07/24] i2c: designware: Add missing 'c' into PCI IDs variable name Andy Shevchenko
2023-11-27 23:54   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 08/24] i2c: designware: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE() Andy Shevchenko
2023-11-20 14:41 ` [PATCH v4 09/24] i2c: designware: Unify terminator in device ID tables Andy Shevchenko
2023-11-27 23:56   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 10/24] i2c: designware: Always provide " Andy Shevchenko
2023-11-20 14:41 ` Andy Shevchenko [this message]
2023-11-20 14:41 ` [PATCH v4 12/24] i2c: designware: Drop return value from dw_i2c_of_configure() Andy Shevchenko
2023-11-20 14:41 ` [PATCH v4 13/24] i2c: designware: Rename dw_i2c_of_configure() -> i2c_dw_of_configure() Andy Shevchenko
2023-11-20 14:41 ` [PATCH v4 14/24] i2c: designware: Consolidate firmware parsing and configuring code Andy Shevchenko
2023-11-20 14:41 ` [PATCH v4 15/24] i2c: designware: Unify the firmware type checks Andy Shevchenko
2023-11-20 14:41 ` [PATCH v4 16/24] i2c: designware: Move exports to I2C_DW namespaces Andy Shevchenko
2023-11-28 17:48   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 17/24] i2c: designware: Remove ->disable() callback Andy Shevchenko
2023-11-29  0:47   ` Andi Shyti
2023-11-20 14:42 ` [PATCH v4 18/24] i2c: designware: Consolidate PM ops Andy Shevchenko
2023-11-29 23:08   ` Andi Shyti
2023-11-20 14:42 ` [PATCH v4 19/24] i2c: designware: Uninline i2c_dw_probe() Andy Shevchenko
2023-11-29 23:21   ` Andi Shyti
2023-11-30 13:28     ` Andy Shevchenko
2023-12-03 22:06       ` Andi Shyti
2023-11-20 14:42 ` [PATCH v4 20/24] i2c: designware: Propagate firmware node Andy Shevchenko
2023-11-29 23:09   ` Andi Shyti
2023-11-20 14:42 ` [PATCH v4 21/24] i2c: designware: Use pci_get_drvdata() Andy Shevchenko
2023-11-29 23:10   ` Andi Shyti
2023-11-20 14:42 ` [PATCH v4 22/24] i2c: designware: Use temporary variable for struct device Andy Shevchenko
2023-11-29 23:12   ` Andi Shyti
2023-11-20 14:42 ` [PATCH v4 23/24] i2c: designware: Get rid of redundant 'else' Andy Shevchenko
2023-11-20 14:42 ` [PATCH v4 24/24] i2c: designware: Fix spelling and other issues in the comments Andy Shevchenko
2023-11-29 23:20   ` Andi Shyti
2023-11-21 14:30 ` [PATCH v4 00/24] i2c: designware: code consolidation & cleanups Jarkko Nikula
2023-11-21 16:08 ` Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231120144641.1660574-12-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jsd@semihalf.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=p.zabel@pengutronix.de \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox