public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Wolfram Sang <wsa@kernel.org>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>
Subject: [PATCH v4 19/24] i2c: designware: Uninline i2c_dw_probe()
Date: Mon, 20 Nov 2023 16:42:01 +0200	[thread overview]
Message-ID: <20231120144641.1660574-20-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20231120144641.1660574-1-andriy.shevchenko@linux.intel.com>

Since i2c_dw_probe() is going to be extended, uninline it to reduce
the noise in the common header.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/i2c/busses/i2c-designware-common.c | 14 ++++++++++++++
 drivers/i2c/busses/i2c-designware-core.h   | 17 ++---------------
 2 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c
index 7c877e380605..1d213bc0bbfa 100644
--- a/drivers/i2c/busses/i2c-designware-common.c
+++ b/drivers/i2c/busses/i2c-designware-common.c
@@ -714,6 +714,20 @@ void i2c_dw_disable(struct dw_i2c_dev *dev)
 }
 EXPORT_SYMBOL_GPL(i2c_dw_disable);
 
+int i2c_dw_probe(struct dw_i2c_dev *dev)
+{
+	switch (dev->mode) {
+	case DW_IC_SLAVE:
+		return i2c_dw_probe_slave(dev);
+	case DW_IC_MASTER:
+		return i2c_dw_probe_master(dev);
+	default:
+		dev_err(dev->dev, "Wrong operation mode: %d\n", dev->mode);
+		return -EINVAL;
+	}
+}
+EXPORT_SYMBOL_GPL(i2c_dw_probe);
+
 static int i2c_dw_prepare(struct device *device)
 {
 	/*
diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h
index f6ebf86dcc6f..7479cb3a450d 100644
--- a/drivers/i2c/busses/i2c-designware-core.h
+++ b/drivers/i2c/busses/i2c-designware-core.h
@@ -10,9 +10,7 @@
  */
 
 #include <linux/bits.h>
-#include <linux/compiler_types.h>
 #include <linux/completion.h>
-#include <linux/dev_printk.h>
 #include <linux/errno.h>
 #include <linux/i2c.h>
 #include <linux/pm.h>
@@ -367,19 +365,6 @@ static inline void i2c_dw_configure_slave(struct dw_i2c_dev *dev) { }
 static inline int i2c_dw_probe_slave(struct dw_i2c_dev *dev) { return -EINVAL; }
 #endif
 
-static inline int i2c_dw_probe(struct dw_i2c_dev *dev)
-{
-	switch (dev->mode) {
-	case DW_IC_SLAVE:
-		return i2c_dw_probe_slave(dev);
-	case DW_IC_MASTER:
-		return i2c_dw_probe_master(dev);
-	default:
-		dev_err(dev->dev, "Wrong operation mode: %d\n", dev->mode);
-		return -EINVAL;
-	}
-}
-
 static inline void i2c_dw_configure(struct dw_i2c_dev *dev)
 {
 	if (i2c_detect_slave_mode(dev->dev))
@@ -388,6 +373,8 @@ static inline void i2c_dw_configure(struct dw_i2c_dev *dev)
 		i2c_dw_configure_master(dev);
 }
 
+int i2c_dw_probe(struct dw_i2c_dev *dev);
+
 #if IS_ENABLED(CONFIG_I2C_DESIGNWARE_BAYTRAIL)
 int i2c_dw_baytrail_probe_lock_support(struct dw_i2c_dev *dev);
 #endif
-- 
2.43.0.rc1.1.gbec44491f096


  parent reply	other threads:[~2023-11-20 14:47 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-20 14:41 [PATCH v4 00/24] i2c: designware: code consolidation & cleanups Andy Shevchenko
2023-11-20 14:41 ` [PATCH v4 01/24] i2c: designware: Fix PM calls order in dw_i2c_plat_probe() Andy Shevchenko
2023-11-26 21:48   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 02/24] i2c: designware: Fix reset call " Andy Shevchenko
2023-11-26 21:57   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 03/24] i2c: designware: Let PCI core to take care about interrupt vectors Andy Shevchenko
2023-11-26 22:03   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 04/24] i2c: designware: Fix lock probe call order in dw_i2c_plat_probe() Andy Shevchenko
2023-11-26 22:23   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 05/24] i2c: designware: Replace a while-loop by for-loop Andy Shevchenko
2023-11-26 22:27   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 06/24] i2c: designware: Save pointer to semaphore callbacks instead of index Andy Shevchenko
2023-11-26 22:38   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 07/24] i2c: designware: Add missing 'c' into PCI IDs variable name Andy Shevchenko
2023-11-27 23:54   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 08/24] i2c: designware: Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE() Andy Shevchenko
2023-11-20 14:41 ` [PATCH v4 09/24] i2c: designware: Unify terminator in device ID tables Andy Shevchenko
2023-11-27 23:56   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 10/24] i2c: designware: Always provide " Andy Shevchenko
2023-11-20 14:41 ` [PATCH v4 11/24] i2c: designware: Drop return value from i2c_dw_acpi_configure() Andy Shevchenko
2023-11-20 14:41 ` [PATCH v4 12/24] i2c: designware: Drop return value from dw_i2c_of_configure() Andy Shevchenko
2023-11-20 14:41 ` [PATCH v4 13/24] i2c: designware: Rename dw_i2c_of_configure() -> i2c_dw_of_configure() Andy Shevchenko
2023-11-20 14:41 ` [PATCH v4 14/24] i2c: designware: Consolidate firmware parsing and configuring code Andy Shevchenko
2023-11-20 14:41 ` [PATCH v4 15/24] i2c: designware: Unify the firmware type checks Andy Shevchenko
2023-11-20 14:41 ` [PATCH v4 16/24] i2c: designware: Move exports to I2C_DW namespaces Andy Shevchenko
2023-11-28 17:48   ` Andi Shyti
2023-11-20 14:41 ` [PATCH v4 17/24] i2c: designware: Remove ->disable() callback Andy Shevchenko
2023-11-29  0:47   ` Andi Shyti
2023-11-20 14:42 ` [PATCH v4 18/24] i2c: designware: Consolidate PM ops Andy Shevchenko
2023-11-29 23:08   ` Andi Shyti
2023-11-20 14:42 ` Andy Shevchenko [this message]
2023-11-29 23:21   ` [PATCH v4 19/24] i2c: designware: Uninline i2c_dw_probe() Andi Shyti
2023-11-30 13:28     ` Andy Shevchenko
2023-12-03 22:06       ` Andi Shyti
2023-11-20 14:42 ` [PATCH v4 20/24] i2c: designware: Propagate firmware node Andy Shevchenko
2023-11-29 23:09   ` Andi Shyti
2023-11-20 14:42 ` [PATCH v4 21/24] i2c: designware: Use pci_get_drvdata() Andy Shevchenko
2023-11-29 23:10   ` Andi Shyti
2023-11-20 14:42 ` [PATCH v4 22/24] i2c: designware: Use temporary variable for struct device Andy Shevchenko
2023-11-29 23:12   ` Andi Shyti
2023-11-20 14:42 ` [PATCH v4 23/24] i2c: designware: Get rid of redundant 'else' Andy Shevchenko
2023-11-20 14:42 ` [PATCH v4 24/24] i2c: designware: Fix spelling and other issues in the comments Andy Shevchenko
2023-11-29 23:20   ` Andi Shyti
2023-11-21 14:30 ` [PATCH v4 00/24] i2c: designware: code consolidation & cleanups Jarkko Nikula
2023-11-21 16:08 ` Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231120144641.1660574-20-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jsd@semihalf.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=p.zabel@pengutronix.de \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox