Re: [PATCH 2/3] USB: dwc3: qcom: fix wakeup after probe deferral

Johan Hovold
2023-11-21T14:35:28Z

On Tue, Nov 21, 2023 at 07:38:18PM +0530, Krishna Kurapati PSSNV wrote:
> >> Just one query. Even if it wakes up after closing the lid and removing
> >> the mouse, wouldn't pm suspend be triggered again later by the system
> >> once it sees that usb is also good to be suspended again ? I presume a
> >> laptop form factor would be having this facility of re-trigerring
> >> suspend. Let me know if this is not the case.
> >
> > No, we generally don't use opportunistic suspend (e.g. unlike android)
> > so the laptop will not suspend again.
> >
> > So this is an actual bug affecting, for example, the Lenovo ThinkPad
> > X13s.

> Thanks for the clarification. I was thinking in android perspective
> only. But if we don't wake up the system upon disconnect, wouldn't the
> controller still be under the assumption that device is connected when
> it is actually not and only realise this when we resume later ?

Correct.

Johan