From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: mohd.syazwan.abdul.halim@intel.com,
Kunwu Chan <chentao@kylinos.cn>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 5/7] iommu/vt-d: Add MTL to quirk list to skip TE disabling
Date: Wed, 22 Nov 2023 11:26:06 +0800 [thread overview]
Message-ID: <20231122032608.165144-6-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20231122032608.165144-1-baolu.lu@linux.intel.com>
From: "Abdul Halim, Mohd Syazwan" <mohd.syazwan.abdul.halim@intel.com>
The VT-d spec requires (10.4.4 Global Command Register, TE field) that:
Hardware implementations supporting DMA draining must drain any in-flight
DMA read/write requests queued within the Root-Complex before switching
address translation on or off and reflecting the status of the command
through the TES field in the Global Status register.
Unfortunately, some integrated graphic devices fail to do so after some
kind of power state transition. As the result, the system might stuck in
iommu_disable_translation(), waiting for the completion of TE transition.
Add MTL to the quirk list for those devices and skips TE disabling if the
qurik hits.
Fixes: b1012ca8dc4f ("iommu/vt-d: Skip TE disabling on quirky gfx dedicated iommu")
Cc: stable@vger.kernel.org
Signed-off-by: Abdul Halim, Mohd Syazwan <mohd.syazwan.abdul.halim@intel.com>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Link: https://lore.kernel.org/r/20231116022324.30120-1-baolu.lu@linux.intel.com
---
drivers/iommu/intel/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index 4c257ccf9dc3..68f121c28fbf 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -5077,7 +5077,7 @@ static void quirk_igfx_skip_te_disable(struct pci_dev *dev)
ver = (dev->device >> 8) & 0xff;
if (ver != 0x45 && ver != 0x46 && ver != 0x4c &&
ver != 0x4e && ver != 0x8a && ver != 0x98 &&
- ver != 0x9a && ver != 0xa7)
+ ver != 0x9a && ver != 0xa7 && ver != 0x7d)
return;
if (risky_device(dev))
--
2.34.1
next prev parent reply other threads:[~2023-11-22 3:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 3:26 [PATCH 0/7] [PULL REQUEST] iommu/vt-d: Fixes for v6.7-rc3 Lu Baolu
2023-11-22 3:26 ` [PATCH 1/7] iommu/vt-d: Support enforce_cache_coherency only for empty domains Lu Baolu
2023-11-22 3:26 ` [PATCH 2/7] iommu/vt-d: Omit devTLB invalidation requests when TES=0 Lu Baolu
2023-11-22 3:26 ` [PATCH 3/7] iommu/vt-d: Disable PCI ATS in legacy passthrough mode Lu Baolu
2023-11-22 3:26 ` [PATCH 4/7] iommu/vt-d: Make context clearing consistent with context mapping Lu Baolu
2023-11-22 3:26 ` Lu Baolu [this message]
2023-11-22 3:26 ` [PATCH 6/7] iommu/vt-d: Fix incorrect cache invalidation for mm notification Lu Baolu
2023-11-22 3:26 ` [PATCH 7/7] iommu/vt-d: Set variable intel_dirty_ops to static Lu Baolu
2023-11-27 10:08 ` [PATCH 0/7] [PULL REQUEST] iommu/vt-d: Fixes for v6.7-rc3 Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122032608.165144-6-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=chentao@kylinos.cn \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohd.syazwan.abdul.halim@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox