Re: [PATCH 10/12] iio: adc: ad9467: convert to backend framework

kernel test robot
2023-11-22T00:55:10Z

Hi Nuno,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on driver-core/driver-core-testing driver-core/driver-core-next driver-core/driver-core-linus robh/for-next linus/master v6.7-rc2 next-20231121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Nuno-Sa-via-B4-Relay/driver-core-allow-modifying-device_links-flags/20231121-182010
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/20231121-dev-iio-backend-v1-10-6a3d542eba35%40analog.com
patch subject: [PATCH 10/12] iio: adc: ad9467: convert to backend framework
config: powerpc-randconfig-r071-20231122 (https://download.01.org/0day-ci/archive/20231122/202311220807.NUS4r7ML-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231122/202311220807.NUS4r7ML-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311220807.NUS4r7ML-lkp@intel.com/

smatch warnings:
drivers/iio/adc/ad9467.c:276 ad9467_get_scale() warn: unsigned 'vref_val' is never less than zero.

vim +/vref_val +276 drivers/iio/adc/ad9467.c

ad67971202381c Michael Hennerich 2020-03-24 270
a78b758afbce92 Nuno Sa 2023-11-21 271 static int ad9467_get_scale(struct ad9467_state *st, int *val, int *val2)
ad67971202381c Michael Hennerich 2020-03-24 272 {
337dbb6ec1acc2 Alexandru Ardelean 2020-09-24 273 unsigned int i, vref_val;
ad67971202381c Michael Hennerich 2020-03-24 274
ad67971202381c Michael Hennerich 2020-03-24 275 vref_val = ad9467_spi_read(st->spi, AN877_ADC_REG_VREF);
d1e957a3e7676f Nuno Sa 2023-11-21 @276 if (vref_val < 0)
d1e957a3e7676f Nuno Sa 2023-11-21 277 return vref_val;
ad67971202381c Michael Hennerich 2020-03-24 278
a78b758afbce92 Nuno Sa 2023-11-21 279 vref_val &= st->info->vref_mask;
ad67971202381c Michael Hennerich 2020-03-24 280
a78b758afbce92 Nuno Sa 2023-11-21 281 for (i = 0; i < st->info->num_scales; i++) {
a78b758afbce92 Nuno Sa 2023-11-21 282 if (vref_val == st->info->scale_table[i][1])
ad67971202381c Michael Hennerich 2020-03-24 283 break;
ad67971202381c Michael Hennerich 2020-03-24 284 }
ad67971202381c Michael Hennerich 2020-03-24 285
a78b758afbce92 Nuno Sa 2023-11-21 286 if (i == st->info->num_scales)
ad67971202381c Michael Hennerich 2020-03-24 287 return -ERANGE;
ad67971202381c Michael Hennerich 2020-03-24 288
a78b758afbce92 Nuno Sa 2023-11-21 289 __ad9467_get_scale(st, i, val, val2);
ad67971202381c Michael Hennerich 2020-03-24 290
ad67971202381c Michael Hennerich 2020-03-24 291 return IIO_VAL_INT_PLUS_MICRO;
ad67971202381c Michael Hennerich 2020-03-24 292 }
ad67971202381c Michael Hennerich 2020-03-24 293

--
0-DAY CI Kernel Test Service