From: Lee Jones <lee@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: "Pavel Machek" <pavel@ucw.cz>,
"Jean-Jacques Hiblot" <jjhiblot@traphandler.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
"Johannes Penßel" <johannes.penssel@gmail.com>,
"Jeremy Soller" <jeremy@system76.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Bagas Sanjaya" <bagasdotme@gmail.com>
Subject: Re: [PATCH] Revert "leds: class: Store the color index in struct led_classdev"
Date: Wed, 22 Nov 2023 11:44:34 +0000 [thread overview]
Message-ID: <20231122114434.GI173820@google.com> (raw)
In-Reply-To: <87v89v9j9t.wl-tiwai@suse.de>
On Tue, 21 Nov 2023, Takashi Iwai wrote:
> On Tue, 21 Nov 2023 16:10:12 +0100,
> Lee Jones wrote:
> >
> > On Tue, 21 Nov 2023 15:26:29 +0100, Takashi Iwai wrote:
> > > This reverts commit c7d80059b086c4986cd994a1973ec7a5d75f8eea.
> > >
> > > The commit caused regressions to a few drivers (such as Logitech
> > > keyboard or System76 ACPI) that already had "color" leds sysfs entry;
> > > now they conflict with the commonly created sysfs of led class.
> > >
> > > For addressing the regression, we revert the commit, so that the
> > > conflicting "color" sysfs entry is removed.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/1] Revert "leds: class: Store the color index in struct led_classdev"
> > commit: 17e1ad377bb1d39260e0594ee284d8e03f64fdfb
>
> It turned out that drivers/leds/rgb/leds-group-multicolor.c
> initializes the cdev->color, and this revert breaks it.
Indeed:
linux/leds-fixes/drivers/leds/rgb/leds-group-multicolor.c: In function ‘leds_gmc_probe’:
linux/leds-fixes/drivers/leds/rgb/leds-group-multicolor.c:109:49: error: ‘struct led_classdev’ has no member named ‘color’
linux/leds-fixes/drivers/leds/rgb/leds-group-multicolor.c:120:13: error: ‘struct led_classdev’ has no member named ‘color’
> So please scratch my previous revert patch.
> I'm going to submit a partial revert instead.
Sure.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-11-22 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 14:26 [PATCH] Revert "leds: class: Store the color index in struct led_classdev" Takashi Iwai
2023-11-21 15:10 ` Lee Jones
2023-11-21 16:13 ` Takashi Iwai
2023-11-22 11:44 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122114434.GI173820@google.com \
--to=lee@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jeremy@system76.com \
--cc=jjhiblot@traphandler.com \
--cc=johannes.penssel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox