* [PATCH v1] pinctrl: intel: use the correct _PM_OPS() export macro
@ 2023-11-22 10:54 Raag Jadav
2023-11-22 11:04 ` Andy Shevchenko
2023-11-22 13:52 ` Mika Westerberg
0 siblings, 2 replies; 3+ messages in thread
From: Raag Jadav @ 2023-11-22 10:54 UTC (permalink / raw)
To: mika.westerberg, andriy.shevchenko, linus.walleij
Cc: linux-gpio, linux-kernel, Raag Jadav
Since we don't have runtime PM handles here, we should be using
EXPORT_NS_GPL_DEV_SLEEP_PM_OPS() macro, so that the compiler can
discard it in case CONFIG_PM_SLEEP=n.
Fixes: b10a74b5c0c1 ("pinctrl: intel: Provide Intel pin control wide PM ops structure")
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/pinctrl/intel/pinctrl-intel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 2367c2747a83..d6f29e6faab7 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -1879,7 +1879,7 @@ static int intel_pinctrl_resume_noirq(struct device *dev)
return 0;
}
-EXPORT_NS_GPL_DEV_PM_OPS(intel_pinctrl_pm_ops, PINCTRL_INTEL) = {
+EXPORT_NS_GPL_DEV_SLEEP_PM_OPS(intel_pinctrl_pm_ops, PINCTRL_INTEL) = {
NOIRQ_SYSTEM_SLEEP_PM_OPS(intel_pinctrl_suspend_noirq, intel_pinctrl_resume_noirq)
};
base-commit: c5860e4a2737a8b29dc426c800d01c5be6aad811
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] pinctrl: intel: use the correct _PM_OPS() export macro
2023-11-22 10:54 [PATCH v1] pinctrl: intel: use the correct _PM_OPS() export macro Raag Jadav
@ 2023-11-22 11:04 ` Andy Shevchenko
2023-11-22 13:52 ` Mika Westerberg
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-11-22 11:04 UTC (permalink / raw)
To: Raag Jadav; +Cc: mika.westerberg, linus.walleij, linux-gpio, linux-kernel
On Wed, Nov 22, 2023 at 04:24:01PM +0530, Raag Jadav wrote:
> Since we don't have runtime PM handles here, we should be using
> EXPORT_NS_GPL_DEV_SLEEP_PM_OPS() macro, so that the compiler can
> discard it in case CONFIG_PM_SLEEP=n.
Obviously correct fix, I've pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] pinctrl: intel: use the correct _PM_OPS() export macro
2023-11-22 10:54 [PATCH v1] pinctrl: intel: use the correct _PM_OPS() export macro Raag Jadav
2023-11-22 11:04 ` Andy Shevchenko
@ 2023-11-22 13:52 ` Mika Westerberg
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2023-11-22 13:52 UTC (permalink / raw)
To: Raag Jadav; +Cc: andriy.shevchenko, linus.walleij, linux-gpio, linux-kernel
On Wed, Nov 22, 2023 at 04:24:01PM +0530, Raag Jadav wrote:
> Since we don't have runtime PM handles here, we should be using
> EXPORT_NS_GPL_DEV_SLEEP_PM_OPS() macro, so that the compiler can
> discard it in case CONFIG_PM_SLEEP=n.
>
> Fixes: b10a74b5c0c1 ("pinctrl: intel: Provide Intel pin control wide PM ops structure")
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-22 18:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-22 10:54 [PATCH v1] pinctrl: intel: use the correct _PM_OPS() export macro Raag Jadav
2023-11-22 11:04 ` Andy Shevchenko
2023-11-22 13:52 ` Mika Westerberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox