From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99C7DC61D97 for ; Wed, 22 Nov 2023 15:35:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344426AbjKVPfk (ORCPT ); Wed, 22 Nov 2023 10:35:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344476AbjKVPfI (ORCPT ); Wed, 22 Nov 2023 10:35:08 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0560919AA; Wed, 22 Nov 2023 07:34:18 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F28D1C433C7; Wed, 22 Nov 2023 15:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700667250; bh=jY5Pv+B2njxLc3k2VGM7ymduhps1lRcahMa6vxZbHPQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZZgEe+5JWCRnZLYGvuUL+/RswY0S5GDMBasopiuoXbdAJWphhJFa9HirI2CDzEdwp GJXxLh9PvumnObV40HjWGYdrZTFo68YvufIw+QO7skwJE3sE5p30GRAtaWC9z2YSgI aA4KmFLJqhqIRzrgpog3oLHTvapW/EXTW1Twd99Xw9FRRB7nX+Qs/Mo5/vCbYv09zC uPFZ0y2zXDnRxgNT4N260OO6tHfY+aMi0yNj2yBPzm6g6uOKK+BRQsvnKZxUFY2EzF vCdKo7JVrW7qvMn3+KEWBq2OGS+k1cCda0+UykdScZTnv/HrMn5rqs8nhWiS4qfeEC AYIAeJtNtVXUg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alex Pakhunov , Vincent Wong , Pavan Chebbi , Jakub Kicinski , Sasha Levin , mchan@broadcom.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 6.5 09/15] tg3: Increment tx_dropped in tg3_tso_bug() Date: Wed, 22 Nov 2023 10:33:11 -0500 Message-ID: <20231122153340.852434-9-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231122153340.852434-1-sashal@kernel.org> References: <20231122153340.852434-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.5.12 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alex Pakhunov [ Upstream commit 17dd5efe5f36a96bd78012594fabe21efb01186b ] tg3_tso_bug() drops a packet if it cannot be segmented for any reason. The number of discarded frames should be incremented accordingly. Signed-off-by: Alex Pakhunov Signed-off-by: Vincent Wong Reviewed-by: Pavan Chebbi Link: https://lore.kernel.org/r/20231113182350.37472-2-alexey.pakhunov@spacex.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/tg3.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 0480b10701d5d..1eef96908084d 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -7875,8 +7875,10 @@ static int tg3_tso_bug(struct tg3 *tp, struct tg3_napi *tnapi, segs = skb_gso_segment(skb, tp->dev->features & ~(NETIF_F_TSO | NETIF_F_TSO6)); - if (IS_ERR(segs) || !segs) + if (IS_ERR(segs) || !segs) { + tnapi->tx_dropped++; goto tg3_tso_bug_end; + } skb_list_walk_safe(segs, seg, next) { skb_mark_not_on_list(seg); -- 2.42.0