From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D26F3C61D97 for ; Wed, 22 Nov 2023 15:46:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344606AbjKVPqU (ORCPT ); Wed, 22 Nov 2023 10:46:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344774AbjKVPpn (ORCPT ); Wed, 22 Nov 2023 10:45:43 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C095F468E; Wed, 22 Nov 2023 07:36:49 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68A22C433AD; Wed, 22 Nov 2023 15:36:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700667409; bh=YFZXv8F51rU+YjubxMZNmPxnUzYIRpbnsaCbW+QtIGw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V9FJGL5iYxjwuMp8vB5ClkY3mQcG2RMIDtZb2zSqUsYL1MMm+Ijs+OxY9C0DSKJLn tZ0EIUrAFINolSYQHuo9q+xMtOaKpCSYkhAl7eGS+jxKCX2TjFssX3VpjBaSxO/Oid wOLCebmkzUH4HiYBby93tiVcmhuhyxBsFdFCXIIZ3AvZxBVGVVGTYbzngf+C8BAYBw ahZ38KzyLUXUxrEwRuJzJ5L3p+G6+0ipMyAZWInlKO+oP8k/FeAJeVMwKNIe1cSdR6 HLXymk1fFHPv9RrMxOjRFILPq2SPwiNZ4u79B/p21KwKHCKHx8UXiqVNRoFqCzwYw+ fCVr+p4TCzfDg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alex Pakhunov , Vincent Wong , Pavan Chebbi , Jakub Kicinski , Sasha Levin , mchan@broadcom.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 4/6] tg3: Increment tx_dropped in tg3_tso_bug() Date: Wed, 22 Nov 2023 10:36:28 -0500 Message-ID: <20231122153635.853495-4-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231122153635.853495-1-sashal@kernel.org> References: <20231122153635.853495-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.299 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alex Pakhunov [ Upstream commit 17dd5efe5f36a96bd78012594fabe21efb01186b ] tg3_tso_bug() drops a packet if it cannot be segmented for any reason. The number of discarded frames should be incremented accordingly. Signed-off-by: Alex Pakhunov Signed-off-by: Vincent Wong Reviewed-by: Pavan Chebbi Link: https://lore.kernel.org/r/20231113182350.37472-2-alexey.pakhunov@spacex.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/tg3.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 84a5bddf614c8..68bb4a2ff7cee 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -7889,8 +7889,10 @@ static int tg3_tso_bug(struct tg3 *tp, struct tg3_napi *tnapi, segs = skb_gso_segment(skb, tp->dev->features & ~(NETIF_F_TSO | NETIF_F_TSO6)); - if (IS_ERR(segs) || !segs) + if (IS_ERR(segs) || !segs) { + tnapi->tx_dropped++; goto tg3_tso_bug_end; + } do { nskb = segs; -- 2.42.0